Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4131)

Unified Diff: chrome/browser/cocoa/about_window_controller.mm

Issue 3655006: Fixes bugs in usage of adding a new tab with a disposition of (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: More mac fixes Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/cocoa/preferences_window_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/about_window_controller.mm
diff --git a/chrome/browser/cocoa/about_window_controller.mm b/chrome/browser/cocoa/about_window_controller.mm
index bb8044c33120b2de94e167bb82e23d41417d3b8d..7d968039124a6078577618aa5706a9424f1c5bdf 100644
--- a/chrome/browser/cocoa/about_window_controller.mm
+++ b/chrome/browser/cocoa/about_window_controller.mm
@@ -13,6 +13,7 @@
#include "base/string_util.h"
#include "base/sys_string_conversions.h"
#include "chrome/browser/browser_list.h"
+#include "chrome/browser/browser_window.h"
#include "chrome/browser/platform_util.h"
#import "chrome/browser/cocoa/background_tile_view.h"
#import "chrome/browser/cocoa/keystone_glue.h"
@@ -620,10 +621,9 @@ static BOOL recentShownUserActionFailedStatus = NO;
// We always create a new window, so there's no need to try to re-use
// an existing one just to pass in the NEW_WINDOW disposition.
Browser* browser = Browser::Create(profile_);
- if (browser) {
- browser->OpenURL(GURL([link UTF8String]), GURL(), NEW_WINDOW,
- PageTransition::LINK);
- }
+ browser->OpenURL(GURL([link UTF8String]), GURL(), NEW_FOREGROUND_TAB,
+ PageTransition::LINK);
+ browser->window()->Show();
return YES;
}
« no previous file with comments | « no previous file | chrome/browser/cocoa/preferences_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698