Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6679)

Unified Diff: chrome/browser/views/options/cookie_filter_page_view.cc

Issue 3655006: Fixes bugs in usage of adding a new tab with a disposition of (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: More mac fixes Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/options/cookie_filter_page_view.cc
diff --git a/chrome/browser/views/options/cookie_filter_page_view.cc b/chrome/browser/views/options/cookie_filter_page_view.cc
index 320445c115b5d8b353e73bc7920b62bc938a932b..d8ab81b5ca210be8454d4b61904839a2e948de17 100644
--- a/chrome/browser/views/options/cookie_filter_page_view.cc
+++ b/chrome/browser/views/options/cookie_filter_page_view.cc
@@ -5,10 +5,9 @@
#include "chrome/browser/views/options/cookie_filter_page_view.h"
#include "app/l10n_util.h"
-#include "chrome/browser/browser.h"
-#include "chrome/browser/browser_window.h"
#include "chrome/browser/host_content_settings_map.h"
#include "chrome/browser/profile.h"
+#include "chrome/browser/show_options_url.h"
#include "chrome/browser/views/options/cookies_view.h"
#include "chrome/common/pref_names.h"
#include "grit/generated_resources.h"
@@ -112,10 +111,6 @@ void CookieFilterPageView::ButtonPressed(views::Button* sender,
// CookieFilterPageView, views::LinkController implementation:
void CookieFilterPageView::LinkActivated(views::Link* source, int event_flags) {
- // We open a new browser window so the Options dialog doesn't get lost
- // behind other windows.
- Browser* browser = Browser::Create(profile());
- browser->OpenURL(GURL(l10n_util::GetString(IDS_FLASH_STORAGE_URL)), GURL(),
- NEW_FOREGROUND_TAB, PageTransition::LINK);
- browser->window()->Show();
+ browser::ShowOptionsURL(profile(),
+ GURL(l10n_util::GetString(IDS_FLASH_STORAGE_URL)));
}
« no previous file with comments | « chrome/browser/views/options/advanced_contents_view.cc ('k') | chrome/browser/views/options/general_page_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698