Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3893)

Unified Diff: chrome/browser/views/options/advanced_contents_view.cc

Issue 3655006: Fixes bugs in usage of adding a new tab with a disposition of (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: More mac fixes Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/options/advanced_contents_view.cc
diff --git a/chrome/browser/views/options/advanced_contents_view.cc b/chrome/browser/views/options/advanced_contents_view.cc
index e6a20902343eea18e69f7e8a17a663703c351626..f99531eed9932cafa2209d0e8ecd2c995cc97c13 100644
--- a/chrome/browser/views/options/advanced_contents_view.cc
+++ b/chrome/browser/views/options/advanced_contents_view.cc
@@ -39,6 +39,7 @@
#include "chrome/browser/renderer_host/resource_dispatcher_host.h"
#include "chrome/browser/safe_browsing/safe_browsing_service.h"
#include "chrome/browser/shell_dialogs.h"
+#include "chrome/browser/show_options_url.h"
#include "chrome/browser/views/browser_dialogs.h"
#include "chrome/browser/views/clear_data_view.h"
#include "chrome/browser/views/list_background.h"
@@ -542,13 +543,10 @@ void PrivacySection::ButtonPressed(
}
void PrivacySection::LinkActivated(views::Link* source, int event_flags) {
- if (source == learn_more_link_) {
- // We open a new browser window so the Options dialog doesn't get lost
- // behind other windows.
- Browser* browser = Browser::Create(profile());
- browser->OpenURL(GURL(l10n_util::GetString(IDS_LEARN_MORE_PRIVACY_URL)),
- GURL(), NEW_WINDOW, PageTransition::LINK);
- }
+ DCHECK(source == learn_more_link_);
+ browser::ShowOptionsURL(
+ profile(),
+ GURL(l10n_util::GetString(IDS_LEARN_MORE_PRIVACY_URL)));
}
void PrivacySection::InitControlLayout() {
@@ -1330,9 +1328,9 @@ void ChromeAppsSection::ButtonPressed(
void ChromeAppsSection::LinkActivated(views::Link* source, int event_flags) {
DCHECK(source == learn_more_link_);
- Browser::Create(profile())->OpenURL(
- GURL(l10n_util::GetString(IDS_LEARN_MORE_BACKGROUND_MODE_URL)), GURL(),
- NEW_WINDOW, PageTransition::LINK);
+ browser::ShowOptionsURL(
+ profile(),
+ GURL(l10n_util::GetString(IDS_LEARN_MORE_BACKGROUND_MODE_URL)));
}
void ChromeAppsSection::InitControlLayout() {
@@ -1436,11 +1434,9 @@ void CloudPrintProxySection::ButtonPressed(views::Button* sender,
} else if (sender == manage_printer_button_) {
UserMetricsRecordAction(
UserMetricsAction("Options_ManageCloudPrinters"), NULL);
- // Open a new browser window for the management tab. The browser
- // will go away when the user closes that tab.
- Browser* browser = Browser::Create(profile());
- browser->OpenURL(CloudPrintURL(profile()).GetCloudPrintServiceManageURL(),
- GURL(), NEW_WINDOW, PageTransition::LINK);
+ browser::ShowOptionsURL(
+ profile(),
+ CloudPrintURL(profile()).GetCloudPrintServiceManageURL());
}
}
« no previous file with comments | « chrome/browser/task_manager/task_manager.cc ('k') | chrome/browser/views/options/cookie_filter_page_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698