Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4287)

Unified Diff: chrome/browser/views/options/general_page_view.cc

Issue 3655006: Fixes bugs in usage of adding a new tab with a disposition of (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: More mac fixes Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/options/general_page_view.cc
diff --git a/chrome/browser/views/options/general_page_view.cc b/chrome/browser/views/options/general_page_view.cc
index b194f0f1148b1ac0dcf1b0e0adf6122cb4aa39fd..e7c4d3e5763565e0963cd14753d9a33264b51659 100644
--- a/chrome/browser/views/options/general_page_view.cc
+++ b/chrome/browser/views/options/general_page_view.cc
@@ -23,6 +23,7 @@
#include "chrome/browser/search_engines/template_url.h"
#include "chrome/browser/search_engines/template_url_model.h"
#include "chrome/browser/search_engines/template_url_model_observer.h"
+#include "chrome/browser/show_options_url.h"
#include "chrome/browser/views/keyword_editor_view.h"
#include "chrome/browser/views/options/managed_prefs_banner_view.h"
#include "chrome/browser/views/options/options_group_view.h"
@@ -451,12 +452,8 @@ void GeneralPageView::HighlightGroup(OptionsGroup highlight_group) {
void GeneralPageView::LinkActivated(views::Link* source, int event_flags) {
DCHECK(source == instant_link_);
- // We open a new browser window so the Options dialog doesn't get lost behind
- // other windows.
- Browser* browser = Browser::Create(profile());
- browser->OpenURL(GURL(browser::kInstantLearnMoreURL),
- GURL(), NEW_FOREGROUND_TAB, PageTransition::LINK);
- browser->window()->Show();
+ browser::ShowOptionsURL(profile(),
+ GURL(browser::kInstantLearnMoreURL));
}
///////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « chrome/browser/views/options/cookie_filter_page_view.cc ('k') | chrome/browser/views/options/plugin_filter_page_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698