Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 3520006: Do not invoke indexed interceptor getters for negative indices. (Closed)

Created:
10 years, 2 months ago by antonm
Modified:
9 years, 4 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev, arv (Not doing code reviews)
Visibility:
Public.

Description

Do not invoke indexed interceptor getters for negative indices. BUG=https://bugs.webkit.org/show_bug.cgi?id=46689 Committed: http://code.google.com/p/v8/source/detail?r=5553

Patch Set 1 #

Patch Set 2 : Addressing Vitaly concern #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -9 lines) Patch
M src/arm/ic-arm.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/ic-x64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +43 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
antonm
10 years, 2 months ago (2010-09-29 14:07:23 UTC) #1
Vitaly,

May you have a look?

Erik, that should solve the issue.  Could you double check it works for you too?

Powered by Google App Engine
This is Rietveld 408576698