src/ia32/ic-ia32.cc - Issue 3520006: Do not invoke indexed interceptor getters for negative indices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/ic-ia32.cc

Issue 3520006: Do not invoke indexed interceptor getters for negative indices. (Closed)

Patch Set: Addressing Vitaly concern Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/ic-ia32.cc

diff --git a/src/ia32/ic-ia32.cc b/src/ia32/ic-ia32.cc

index 413c36e922764e396fbf50688368e29dd35faa48..a2990a20e3f2583bdea9641e3f9d04291865295d 100644

--- a/src/ia32/ic-ia32.cc

+++ b/src/ia32/ic-ia32.cc

@@ -885,8 +885,8 @@ void KeyedLoadIC::GenerateIndexedInterceptor(MacroAssembler* masm) {

__ test(edx, Immediate(kSmiTagMask));

__ j(zero, &slow, not_taken);

- // Check that the key is a smi.

- __ test(eax, Immediate(kSmiTagMask));

+ // Check that the key is an array index, that is Uint32.

+ __ test(eax, Immediate(kSmiTagMask | kSmiSignMask));

__ j(not_zero, &slow, not_taken);

// Get the map of the receiver.

« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »