Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: src/arm/ic-arm.cc

Issue 3520006: Do not invoke indexed interceptor getters for negative indices. (Closed)
Patch Set: Addressing Vitaly concern Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1566 matching lines...) Expand 10 before | Expand all | Expand 10 after
1577 // ---------- S t a t e -------------- 1577 // ---------- S t a t e --------------
1578 // -- lr : return address 1578 // -- lr : return address
1579 // -- r0 : key 1579 // -- r0 : key
1580 // -- r1 : receiver 1580 // -- r1 : receiver
1581 // ----------------------------------- 1581 // -----------------------------------
1582 Label slow; 1582 Label slow;
1583 1583
1584 // Check that the receiver isn't a smi. 1584 // Check that the receiver isn't a smi.
1585 __ BranchOnSmi(r1, &slow); 1585 __ BranchOnSmi(r1, &slow);
1586 1586
1587 // Check that the key is a smi. 1587 // Check that the key is an array index, that is Uint32.
1588 __ BranchOnNotSmi(r0, &slow); 1588 __ tst(r0, Operand(kSmiTagMask | kSmiSignMask));
1589 __ b(ne, &slow);
1589 1590
1590 // Get the map of the receiver. 1591 // Get the map of the receiver.
1591 __ ldr(r2, FieldMemOperand(r1, HeapObject::kMapOffset)); 1592 __ ldr(r2, FieldMemOperand(r1, HeapObject::kMapOffset));
1592 1593
1593 // Check that it has indexed interceptor and access checks 1594 // Check that it has indexed interceptor and access checks
1594 // are not enabled for this object. 1595 // are not enabled for this object.
1595 __ ldrb(r3, FieldMemOperand(r2, Map::kBitFieldOffset)); 1596 __ ldrb(r3, FieldMemOperand(r2, Map::kBitFieldOffset));
1596 __ and_(r3, r3, Operand(kSlowCaseBitFieldMask)); 1597 __ and_(r3, r3, Operand(kSlowCaseBitFieldMask));
1597 __ cmp(r3, Operand(1 << Map::kHasIndexedInterceptor)); 1598 __ cmp(r3, Operand(1 << Map::kHasIndexedInterceptor));
1598 __ b(ne, &slow); 1599 __ b(ne, &slow);
(...skipping 651 matching lines...) Expand 10 before | Expand all | Expand 10 after
2250 GenerateMiss(masm); 2251 GenerateMiss(masm);
2251 } 2252 }
2252 2253
2253 2254
2254 #undef __ 2255 #undef __
2255 2256
2256 2257
2257 } } // namespace v8::internal 2258 } } // namespace v8::internal
2258 2259
2259 #endif // V8_TARGET_ARCH_ARM 2260 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698