Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: src/x64/ic-x64.cc

Issue 3520006: Do not invoke indexed interceptor getters for negative indices. (Closed)
Patch Set: Addressing Vitaly concern Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/stub-cache.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 875 matching lines...) Expand 10 before | Expand all | Expand 10 after
886 // ----------- S t a t e ------------- 886 // ----------- S t a t e -------------
887 // -- rax : key 887 // -- rax : key
888 // -- rdx : receiver 888 // -- rdx : receiver
889 // -- rsp[0] : return address 889 // -- rsp[0] : return address
890 // ----------------------------------- 890 // -----------------------------------
891 Label slow; 891 Label slow;
892 892
893 // Check that the receiver isn't a smi. 893 // Check that the receiver isn't a smi.
894 __ JumpIfSmi(rdx, &slow); 894 __ JumpIfSmi(rdx, &slow);
895 895
896 // Check that the key is a smi. 896 // Check that the key is an array index, that is Uint32.
897 __ JumpIfNotSmi(rax, &slow); 897 __ JumpIfNotPositiveSmi(rax, &slow);
898 898
899 // Get the map of the receiver. 899 // Get the map of the receiver.
900 __ movq(rcx, FieldOperand(rdx, HeapObject::kMapOffset)); 900 __ movq(rcx, FieldOperand(rdx, HeapObject::kMapOffset));
901 901
902 // Check that it has indexed interceptor and access checks 902 // Check that it has indexed interceptor and access checks
903 // are not enabled for this object. 903 // are not enabled for this object.
904 __ movb(rcx, FieldOperand(rcx, Map::kBitFieldOffset)); 904 __ movb(rcx, FieldOperand(rcx, Map::kBitFieldOffset));
905 __ andb(rcx, Immediate(kSlowCaseBitFieldMask)); 905 __ andb(rcx, Immediate(kSlowCaseBitFieldMask));
906 __ cmpb(rcx, Immediate(1 << Map::kHasIndexedInterceptor)); 906 __ cmpb(rcx, Immediate(1 << Map::kHasIndexedInterceptor));
907 __ j(not_zero, &slow); 907 __ j(not_zero, &slow);
(...skipping 989 matching lines...) Expand 10 before | Expand all | Expand 10 after
1897 GenerateMiss(masm); 1897 GenerateMiss(masm);
1898 } 1898 }
1899 1899
1900 1900
1901 #undef __ 1901 #undef __
1902 1902
1903 1903
1904 } } // namespace v8::internal 1904 } } // namespace v8::internal
1905 1905
1906 #endif // V8_TARGET_ARCH_X64 1906 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/stub-cache.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698