src/stub-cache.cc - Issue 3520006: Do not invoke indexed interceptor getters for negative indices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/stub-cache.cc

Issue 3520006: Do not invoke indexed interceptor getters for negative indices. (Closed)

Patch Set: Addressing Vitaly concern Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/stub-cache.cc

diff --git a/src/stub-cache.cc b/src/stub-cache.cc

index 6b41577ea860cde740974881832d9e82e54ae4d6..e6df1b49e31c9b4fda64dff511608bb7bc1e6a50 100644

--- a/src/stub-cache.cc

+++ b/src/stub-cache.cc

@@ -988,6 +988,7 @@ Object* StoreInterceptorProperty(Arguments args) {

Object* KeyedLoadPropertyWithInterceptor(Arguments args) {

JSObject* receiver = JSObject::cast(args[0]);

+ ASSERT(Smi::cast(args[1])->value() >= 0);

uint32_t index = Smi::cast(args[1])->value();

return receiver->GetElementWithInterceptor(receiver, index);

}

« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/x64/ic-x64.cc » ('j') | no next file with comments »