Issue 342092: Eliminate WebViewImpl's dependency on WebDevToolsAgentImpl....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342092: Eliminate WebViewImpl's dependency on WebDevToolsAgentImpl.... (Closed)

Created:
11 years, 1 month ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Eliminate WebViewImpl's dependency on WebDevToolsAgentImpl. This CL decouples the implementation of WebDevToolsAgent from the implementation of WebViewImpl. While this allows me to postpone the uplift of glue/devtools into webkit/api/src, I think it also has the advantage of simplifying dependencies. WebDevToolsAgentPrivate is introduced for the method calls made by the FrameLoaderClientImpl to the WebDevToolsAgentImpl. R=dglazkov BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -73 lines)			Patch
M	chrome/renderer/print_web_view_helper.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/renderer/render_view.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View		4 chunks	+4 lines, -6 lines	0 comments	Download
M	webkit/api/public/WebDevToolsAgent.h	View		2 chunks	+7 lines, -4 lines	0 comments	Download
M	webkit/api/public/WebDevToolsFrontend.h	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	webkit/api/public/WebView.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/api/public/WebViewClient.h	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
M	webkit/api/src/FrameLoaderClientImpl.cpp	View		4 chunks	+5 lines, -9 lines	0 comments	Download
M	webkit/api/src/InspectorClientImpl.cpp	View		3 chunks	+2 lines, -5 lines	0 comments	Download
A	webkit/api/src/WebDevToolsAgentPrivate.h	View		1 chunk	+57 lines, -0 lines	0 comments	Download
M	webkit/api/src/WebViewImpl.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/api/src/WebViewImpl.cpp	View		6 chunks	+8 lines, -15 lines	0 comments	Download
M	webkit/glue/webdevtoolsagent_impl.h	View	1	4 chunks	+7 lines, -10 lines	0 comments	Download
M	webkit/glue/webdevtoolsagent_impl.cc	View		4 chunks	+12 lines, -6 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

Over to dglazkov for review per pfeldman...

11 years, 1 month ago (2009-11-03 18:28:20 UTC) #2

LGTM.

Expand Messages | Collapse Messages