Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: webkit/glue/webdevtoolsagent_impl.cc

Issue 342092: Eliminate WebViewImpl's dependency on WebDevToolsAgentImpl.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webdevtoolsagent_impl.h ('k') | webkit/tools/test_shell/test_webview_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webdevtoolsagent_impl.cc
===================================================================
--- webkit/glue/webdevtoolsagent_impl.cc (revision 30797)
+++ webkit/glue/webdevtoolsagent_impl.cc (working copy)
@@ -30,6 +30,7 @@
#include "webkit/api/public/WebString.h"
#include "webkit/api/public/WebURL.h"
#include "webkit/api/public/WebURLRequest.h"
+#include "webkit/api/src/WebFrameImpl.h"
#include "webkit/api/src/WebViewImpl.h"
#include "webkit/glue/devtools/bound_object.h"
#include "webkit/glue/devtools/debugger_agent_impl.h"
@@ -159,19 +160,18 @@
DebuggerAgentManager::OnNavigate();
}
-void WebDevToolsAgentImpl::DidCommitLoadForFrame(
- WebViewImpl* webview,
- WebFrame* frame,
+void WebDevToolsAgentImpl::didCommitProvisionalLoad(
+ WebFrameImpl* webframe,
bool is_new_navigation) {
if (!attached_) {
return;
}
- WebDataSource* ds = frame->dataSource();
+ WebDataSource* ds = webframe->dataSource();
const WebURLRequest& request = ds->request();
WebURL url = ds->hasUnreachableURL() ?
ds->unreachableURL() :
request.url();
- if (webview->mainFrame() == frame) {
+ if (!webframe->parent()) {
ResetInspectorFrontendProxy();
tools_agent_delegate_stub_->FrameNavigate(
webkit_glue::WebURLToKURL(url).string());
@@ -180,7 +180,7 @@
}
}
-void WebDevToolsAgentImpl::WindowObjectCleared(WebFrameImpl* webframe) {
+void WebDevToolsAgentImpl::didClearWindowObject(WebFrameImpl* webframe) {
DebuggerAgentManager::SetHostId(webframe, host_id_);
if (attached_) {
// Push context id into the client if it is already attached.
@@ -461,6 +461,12 @@
namespace WebKit {
// static
+WebDevToolsAgent* WebDevToolsAgent::create(WebView* webview,
+ WebDevToolsAgentClient* client) {
+ return new WebDevToolsAgentImpl(static_cast<WebViewImpl*>(webview), client);
+}
+
+// static
void WebDevToolsAgent::executeDebuggerCommand(
const WebString& command,
int caller_id) {
« no previous file with comments | « webkit/glue/webdevtoolsagent_impl.h ('k') | webkit/tools/test_shell/test_webview_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698