Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: webkit/api/public/WebDevToolsAgent.h

Issue 342092: Eliminate WebViewImpl's dependency on WebDevToolsAgentImpl.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | webkit/api/public/WebDevToolsFrontend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/api/public/WebDevToolsAgent.h
===================================================================
--- webkit/api/public/WebDevToolsAgent.h (revision 30797)
+++ webkit/api/public/WebDevToolsAgent.h (working copy)
@@ -34,11 +34,17 @@
#include "WebCommon.h"
namespace WebKit {
+class WebDevToolsAgentClient;
class WebString;
+class WebView;
struct WebPoint;
class WebDevToolsAgent {
public:
+ WEBKIT_API static WebDevToolsAgent* create(WebView*, WebDevToolsAgentClient*);
+
+ virtual ~WebDevToolsAgent() {}
+
virtual void attach() = 0;
virtual void detach() = 0;
@@ -63,10 +69,7 @@
// Installs dispatch handle that is going to be called periodically
// while on a breakpoint.
- static void setMessageLoopDispatchHandler(MessageLoopDispatchHandler);
-
-protected:
- ~WebDevToolsAgent() {}
+ WEBKIT_API static void setMessageLoopDispatchHandler(MessageLoopDispatchHandler);
};
} // namespace WebKit
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | webkit/api/public/WebDevToolsFrontend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698