Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: webkit/api/src/WebViewImpl.cpp

Issue 342092: Eliminate WebViewImpl's dependency on WebDevToolsAgentImpl.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/api/src/WebViewImpl.h ('k') | webkit/glue/webdevtoolsagent_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/api/src/WebViewImpl.cpp
===================================================================
--- webkit/api/src/WebViewImpl.cpp (revision 30797)
+++ webkit/api/src/WebViewImpl.cpp (working copy)
@@ -77,6 +77,7 @@
#include "Settings.h"
#include "TypingCommand.h"
#include "WebAccessibilityObject.h"
+#include "WebDevToolsAgentPrivate.h"
#include "WebDragData.h"
#include "WebFrameImpl.h"
#include "WebInputEvent.h"
@@ -99,9 +100,6 @@
#include "RenderTheme.h"
#endif
-// FIXME
-#include "webkit/glue/webdevtoolsagent_impl.h"
-
// Get rid of WTF's pow define so we can use std::pow.
#undef pow
#include <cmath> // for std::pow
@@ -176,12 +174,6 @@
frame->initializeAsMainFrame(this);
- if (m_client) {
- WebDevToolsAgentClient* toolsClient = m_client->devToolsAgentClient();
- if (toolsClient)
- m_devToolsAgent.set(new WebDevToolsAgentImpl(this, toolsClient));
- }
-
// Restrict the access to the local file system
// (see WebView.mm WebView::_commonInitializationWithFrameName).
SecurityOrigin::setLocalLoadPolicy(SecurityOrigin::AllowLocalLoadsForLocalOnly);
@@ -777,7 +769,7 @@
m_page.clear();
}
- // Should happen after m_page.reset().
+ // Should happen after m_page.clear().
if (m_devToolsAgent.get())
m_devToolsAgent.clear();
@@ -1498,6 +1490,12 @@
return m_devToolsAgent.get();
}
+void WebViewImpl::setDevToolsAgent(WebDevToolsAgent* devToolsAgent)
+{
+ ASSERT(!m_devToolsAgent.get()); // May only set once!
+ m_devToolsAgent.set(static_cast<WebDevToolsAgentPrivate*>(devToolsAgent));
+}
+
WebAccessibilityObject WebViewImpl::accessibilityObject()
{
if (!mainFrameImpl())
@@ -1583,11 +1581,6 @@
return false;
}
-WebDevToolsAgentImpl* WebViewImpl::devToolsAgentImpl()
-{
- return m_devToolsAgent.get();
-}
-
void WebViewImpl::setIsTransparent(bool isTransparent)
{
// Set any existing frames to be transparent.
« no previous file with comments | « webkit/api/src/WebViewImpl.h ('k') | webkit/glue/webdevtoolsagent_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698