Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: webkit/glue/webdevtoolsagent_impl.h

Issue 342092: Eliminate WebViewImpl's dependency on WebDevToolsAgentImpl.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/api/src/WebViewImpl.cpp ('k') | webkit/glue/webdevtoolsagent_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webdevtoolsagent_impl.h
===================================================================
--- webkit/glue/webdevtoolsagent_impl.h (revision 30797)
+++ webkit/glue/webdevtoolsagent_impl.h (working copy)
@@ -10,7 +10,7 @@
#include <wtf/OwnPtr.h>
#include "v8.h"
-#include "webkit/api/public/WebDevToolsAgent.h"
+#include "webkit/api/src/WebDevToolsAgentPrivate.h"
#include "webkit/glue/devtools/devtools_rpc.h"
#include "webkit/glue/devtools/apu_agent_delegate.h"
#include "webkit/glue/devtools/tools_agent.h"
@@ -35,7 +35,7 @@
class DebuggerAgentImpl;
class Value;
-class WebDevToolsAgentImpl : public WebKit::WebDevToolsAgent,
+class WebDevToolsAgentImpl : public WebKit::WebDevToolsAgentPrivate,
public ToolsAgent,
public DevToolsRpc::Delegate {
public:
@@ -57,6 +57,11 @@
int call_id,
int identifier);
+ // WebDevToolsAgentPrivate implementation.
+ virtual void didClearWindowObject(WebKit::WebFrameImpl* frame);
+ virtual void didCommitProvisionalLoad(
+ WebKit::WebFrameImpl* frame, bool is_new_navigation);
+
// WebDevToolsAgent implementation.
virtual void attach();
virtual void detach();
@@ -78,14 +83,6 @@
const WebCore::String& param2,
const WebCore::String& param3);
- // Methods called by the glue.
- void SetMainFrameDocumentReady(bool ready);
- void DidCommitLoadForFrame(WebKit::WebViewImpl* webview,
- WebKit::WebFrame* frame,
- bool is_new_navigation);
-
- void WindowObjectCleared(WebKit::WebFrameImpl* webframe);
-
void ForceRepaint();
int host_id() { return host_id_; }
« no previous file with comments | « webkit/api/src/WebViewImpl.cpp ('k') | webkit/glue/webdevtoolsagent_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698