Issue 338001: Get the About panel to align its links correctly,

Issue 338001: Get the About panel to align its links correctly, (Closed)

Created:
11 years, 2 months ago by DaveMoore

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Get the About panel to align its links correctly, but undo a previous change to the way we measure strings in pango. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29943

Patch Set 2 : Found some leftover cruft in files. #

Total comments: 6

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -18 lines)			Patch
M	app/gfx/canvas_linux.cc	View		2 chunks	+2 lines, -8 lines	0 comments	Download
M	app/gfx/font_skia.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status_area_view.cc	View	1	2 chunks	+0 lines, -6 lines	2 comments	Download
M	chrome/browser/views/about_chrome_view.cc	View	1	1 chunk	+7 lines, -2 lines	2 comments	Download
M	views/controls/label.cc	View		1 chunk	+6 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

http://codereview.chromium.org/338001/diff/1001/2003 File chrome/browser/chromeos/status_area_view.cc (left): http://codereview.chromium.org/338001/diff/1001/2003#oldcode36 Line 36: // Number of pixels to adjust the y ...

11 years, 2 months ago (2009-10-23 18:06:29 UTC) #2

DaveMoore

11 years, 2 months ago (2009-10-23 18:11:10 UTC) #3

Evan Stade

11 years, 2 months ago (2009-10-23 20:30:00 UTC) #4

lgtm

-- Evan Stade



On Fri, Oct 23, 2009 at 11:11 AM,  <davemoore@chromium.org> wrote:
>
> http://codereview.chromium.org/338001/diff/1001/2003
> File chrome/browser/chromeos/status_area_view.cc (left):
>
> http://codereview.chromium.org/338001/diff/1001/2003#oldcode36
> Line 36: // Number of pixels to adjust the y value of the clock.
> On 2009/10/23 18:06:29, Evan Stade wrote:
>>
>> this change releated?
>
> Yes...it was correcting for bad positioning.
>
> http://codereview.chromium.org/338001/diff/1001/2004
> File chrome/browser/views/about_chrome_view.cc (right):
>
> http://codereview.chromium.org/338001/diff/1001/2004#newcode490
> Line 490: int y = position->height();
> On 2009/10/23 18:06:29, Evan Stade wrote:
>>
>> is there a functional change here?
>
> No...making it more readable.
>
> http://codereview.chromium.org/338001/diff/1001/2005
> File views/controls/label.cc (right):
>
> http://codereview.chromium.org/338001/diff/1001/2005#newcode267
> Line 267: int w = 0, h = 0;
> On 2009/10/23 18:06:29, Evan Stade wrote:
>>
>> nit: move declaration to where it's used
>
> To me...this is where it's used. All three declarations are used in the
> next ling of code.
>
> http://codereview.chromium.org/338001
>

Expand Messages | Collapse Messages