Get the About panel to align its links correctly,

chrome/browser/views/about_chrome_view.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/about_chrome_view.h"
 
 #include "app/gfx/canvas.h"
 #include "app/gfx/color_utils.h"
 #include "base/i18n/word_iterator.h"
 #include "app/l10n_util.h"
@@ skipping 468 matching lines @@
 
     run_start = run_end;  // Advance over what we just drew.
   }
 
   // If the caller is interested in placing a link after this text blurb, we
   // figure out here where to place it.
   if (link && rect) {
     gfx::Size sz = link->GetPreferredSize();
     gfx::Insets insets = link->GetInsets();
     WrapIfWordDoesntFit(sz.width(), font.height(), position, bounds);
-    *rect = gfx::Rect(position->width(), position->height() - insets.top(),
-                      sz.width(), sz.height());
+    int x = position->width();
+    int y = position->height();

[Evan Stade, 2009/10/23 18:06:29]

is there a functional change here?

[DaveMoore, 2009/10/23 18:11:10]

No...making it more readable.

+
+    // Links have a border to allow them to be focused.
+    y -= insets.top();
+
+    *rect = gfx::Rect(x, y, sz.width(), sz.height());
 
     // Go from relative pixel coordinates (within the label we are drawing on)
     // to absolute pixel coordinates (relative to the top left corner of the
     // dialog content).
     rect->Offset(bounds.x(), bounds.y());
     // And leave some space to draw the link in.
     position->Enlarge(sz.width(), 0);
   }
 }
 
@@ skipping 351 matching lines @@
   View* parent = GetParent();
   parent->Layout();
 
   // Check button may have appeared/disappeared. We cannot call this during
   // ViewHierarchyChanged because the |window()| pointer hasn't been set yet.
   if (window())
     GetDialogClientView()->UpdateDialogButtons();
 }
 
 #endif