Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Unified Diff: chrome/browser/views/about_chrome_view.cc

Issue 338001: Get the About panel to align its links correctly, (Closed)
Patch Set: Found some leftover cruft in files. Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/about_chrome_view.cc
diff --git a/chrome/browser/views/about_chrome_view.cc b/chrome/browser/views/about_chrome_view.cc
old mode 100644
new mode 100755
index 63fabce096da6ddb05938fe99d7db8935595cc62..c4b2fdd5b656ca9b61828dd71136fb4ab0063fa8
--- a/chrome/browser/views/about_chrome_view.cc
+++ b/chrome/browser/views/about_chrome_view.cc
@@ -486,8 +486,13 @@ void AboutChromeView::DrawTextAndPositionUrl(gfx::Canvas* canvas,
gfx::Size sz = link->GetPreferredSize();
gfx::Insets insets = link->GetInsets();
WrapIfWordDoesntFit(sz.width(), font.height(), position, bounds);
- *rect = gfx::Rect(position->width(), position->height() - insets.top(),
- sz.width(), sz.height());
+ int x = position->width();
+ int y = position->height();
Evan Stade 2009/10/23 18:06:29 is there a functional change here?
DaveMoore 2009/10/23 18:11:10 No...making it more readable.
+
+ // Links have a border to allow them to be focused.
+ y -= insets.top();
+
+ *rect = gfx::Rect(x, y, sz.width(), sz.height());
// Go from relative pixel coordinates (within the label we are drawing on)
// to absolute pixel coordinates (relative to the top left corner of the

Powered by Google App Engine
This is Rietveld 408576698