Get the About panel to align its links correctly,

chrome/browser/chromeos/status_area_view.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/status_area_view.h"
 
 #include <algorithm>
 
 #include "app/gfx/canvas.h"
 #include "app/l10n_util.h"
@@ skipping 15 matching lines @@
 #include "grit/theme_resources.h"
 #include "views/controls/menu/menu.h"
 #include "views/controls/menu/simple_menu_model.h"
 
 namespace {
 
 // Number of pixels to pad on the left border.
 const int kLeftBorder = 1;
 // Number of pixels to separate the clock from the next item on the right.
 const int kClockSeparation = 4;
-// Number of pixels to adjust the y value of the clock.

[Evan Stade, 2009/10/23 18:06:29]

this change releated?

[DaveMoore, 2009/10/23 18:11:10]

Yes...it was correcting for bad positioning.

-const int kClockYAdjustment = 2;
 
 // BrowserWindowGtk tiles its image with this offset
 const int kCustomFrameBackgroundVerticalOffset = 15;
 
 class OptionsMenuModel : public views::SimpleMenuModel,
                          public views::SimpleMenuModel::Delegate {
  public:
   // These extra command IDs must be unique when combined with the options,
   // so we just pick up the numbering where that stops.
   enum OtherCommands {
@@ skipping 118 matching lines @@
 void StatusAreaView::Layout() {
   int cur_x = kLeftBorder;
   for (int i = 0; i < GetChildViewCount(); i++) {
     views::View* cur = GetChildViewAt(i);
     gfx::Size cur_size = cur->GetPreferredSize();
     int cur_y = (height() - cur_size.height()) / 2;
 
     // Handle odd number of pixels.
     cur_y += (height() - cur_size.height()) % 2;
 
-    // Adjustment to make clock line up right.
-    if (cur == clock_view_)
-      cur_y += kClockYAdjustment;
-
     // Put next in row horizontally, and center vertically.
     cur->SetBounds(cur_x, cur_y, cur_size.width(), cur_size.height());
 
     cur_x += cur_size.width();
 
     // Buttons have built in padding, but clock doesn't.
     if (cur == clock_view_)
       cur_x += kClockSeparation;
   }
 }
@@ skipping 87 matching lines @@
 }
 
 void StatusAreaView::ExecuteCommand(int command_id) {
   browser_->ExecuteCommand(command_id);
 }
 
 void StatusAreaView::RunMenu(views::View* source, const gfx::Point& pt) {
   CreateAppMenu();
   app_menu_menu_->RunMenuAt(pt, views::Menu2::ALIGN_TOPRIGHT);
 }