Issue 3226005: Refactory UI to grab shortcut keys, and tests to not look for triggers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3226005: Refactory UI to grab shortcut keys, and tests to not look for triggers. (Closed)

Created:
10 years, 3 months ago by Tammo Spalink

Modified:
9 years, 7 months ago

Reviewers:
Hung-Te, Tom Wai-Hong Tam, Nick Sanders

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

Refactory UI to grab shortcut keys, and tests to not look for triggers. Clean up audio test to not create extra windows -- needed since some library parameters changed to inconvenience old behavior. Change-Id: I92a1e1c40ad6d282945bdce60c52b3153e2b9f54

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+267 lines, -389 lines)			Patch
M	client/bin/factory.py	View	3 chunks	+38 lines, -38 lines	0 comments	Download
M	client/bin/factory_ui	View	11 chunks	+66 lines, -42 lines	0 comments	Download
M	client/bin/factory_ui_lib.py	View	4 chunks	+40 lines, -51 lines	0 comments	Download
M	client/deps/factory/startx.sh	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	client/site_tests/factory_Audio/factory_Audio.py	View	5 chunks	+45 lines, -78 lines	0 comments	Download
M	client/site_tests/factory_Camera/factory_Camera.py	View	3 chunks	+4 lines, -9 lines	0 comments	Download
M	client/site_tests/factory_DeveloperRecovery/factory_DeveloperRecovery.py	View	3 chunks	+3 lines, -18 lines	0 comments	Download
M	client/site_tests/factory_Display/factory_Display.py	View	3 chunks	+2 lines, -10 lines	0 comments	Download
M	client/site_tests/factory_Dummy/factory_Dummy.py	View	3 chunks	+2 lines, -9 lines	0 comments	Download
M	client/site_tests/factory_ExtDisplay/factory_ExtDisplay.py	View	3 chunks	+4 lines, -12 lines	0 comments	Download
M	client/site_tests/factory_ExternalStorage/factory_ExternalStorage.py	View	4 chunks	+1 line, -19 lines	0 comments	Download
M	client/site_tests/factory_Keyboard/factory_Keyboard.py	View	6 chunks	+7 lines, -16 lines	0 comments	Download
M	client/site_tests/factory_Leds/factory_Leds.py	View	2 chunks	+2 lines, -11 lines	0 comments	Download
M	client/site_tests/factory_LightSensor/factory_LightSensor.py	View	3 chunks	+7 lines, -16 lines	0 comments	Download
M	client/site_tests/factory_Review/factory_Review.py	View	2 chunks	+1 line, -16 lines	0 comments	Download
M	client/site_tests/factory_ScriptWrapper/factory_ScriptWrapper.py	View	3 chunks	+3 lines, -10 lines	0 comments	Download
M	client/site_tests/factory_Touchpad/factory_Touchpad.py	View	5 chunks	+4 lines, -20 lines	0 comments	Download
M	client/site_tests/suite_Factory/control	View	4 chunks	+31 lines, -8 lines	0 comments	Download
M	client/site_tests/suite_Factory/test_list	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages