Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: client/site_tests/factory_ExtDisplay/factory_ExtDisplay.py

Issue 3226005: Refactory UI to grab shortcut keys, and tests to not look for triggers. (Closed) Base URL: http://git.chromium.org/git/autotest.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/site_tests/factory_ExtDisplay/factory_ExtDisplay.py
diff --git a/client/site_tests/factory_ExtDisplay/factory_ExtDisplay.py b/client/site_tests/factory_ExtDisplay/factory_ExtDisplay.py
index 176c31925c73843d57c6e7ddad8a1ea13435a5f3..3226c01e7482c51a0a73359878ef783fc28ed658 100644
--- a/client/site_tests/factory_ExtDisplay/factory_ExtDisplay.py
+++ b/client/site_tests/factory_ExtDisplay/factory_ExtDisplay.py
@@ -109,8 +109,6 @@ class factory_ExtDisplay(test.test):
self.goto_next_subtest()
elif event.keyval == ord('Q'):
gtk.main_quit()
- else:
- self._ft_state.exit_on_trigger(event)
# evaluating a new subtest now
if subtest_name is not self._current_subtest[0]:
@@ -161,18 +159,14 @@ class factory_ExtDisplay(test.test):
self._sample=sample
def run_once(self,
- test_widget_size=None,
- trigger_set=None,
has_audio=False,
- sample=None,
- ):
+ sample=None):
factory.log('%s run_once' % self.__class__)
- # because audio files relative to that
+
+ # Src contains the audio files.
os.chdir(self.autodir)
- self._ft_state = ful.State(trigger_set=trigger_set)
- self._test_widget_size = test_widget_size
self._started = False
if has_audio:
@@ -198,9 +192,7 @@ class factory_ExtDisplay(test.test):
self.goto_next_subtest()
self.start_subtest()
- self._ft_state.run_test_widget(
- test_widget=vbox,
- test_widget_size=test_widget_size,
+ ful.run_test_widget(self.job, vbox,
window_registration_callback=self.register_callbacks)
failed_set = set(name for name, status in self._status_map.items()
« no previous file with comments | « client/site_tests/factory_Dummy/factory_Dummy.py ('k') | client/site_tests/factory_ExternalStorage/factory_ExternalStorage.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698