Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9013)

Unified Diff: client/site_tests/factory_Review/factory_Review.py

Issue 3226005: Refactory UI to grab shortcut keys, and tests to not look for triggers. (Closed) Base URL: http://git.chromium.org/git/autotest.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/site_tests/factory_Review/factory_Review.py
diff --git a/client/site_tests/factory_Review/factory_Review.py b/client/site_tests/factory_Review/factory_Review.py
index 0cbb191caa748466e841c1ad91c041336f5cf5a5..d7c6665d490f0cd63e90e88625302669dd456216 100644
--- a/client/site_tests/factory_Review/factory_Review.py
+++ b/client/site_tests/factory_Review/factory_Review.py
@@ -28,24 +28,12 @@ from autotest_lib.client.common_lib import error
class factory_Review(test.test):
version = 1
- def key_release_callback(self, widget, event):
- self._ft_state.exit_on_trigger(event)
- return True
-
- def register_callbacks(self, window):
- window.connect('key-release-event', self.key_release_callback)
- window.add_events(gdk.KEY_RELEASE_MASK)
-
def run_once(self,
- test_widget_size=None,
- trigger_set=None,
status_file_path=None,
test_list=None):
factory.log('%s run_once' % self.__class__)
- self._ft_state = ful.State(trigger_set)
-
status_map = factory.StatusMap(test_list, status_file_path)
untested = status_map.filter(ful.UNTESTED)
passed = status_map.filter(ful.PASSED)
@@ -69,9 +57,6 @@ class factory_Review(test.test):
test_widget.modify_bg(gtk.STATE_NORMAL, ful.BLACK)
test_widget.add(vbox)
- self._ft_state.run_test_widget(
- test_widget=test_widget,
- test_widget_size=test_widget_size,
- window_registration_callback=self.register_callbacks)
+ ful.run_test_widget(self.job, test_widget)
factory.log('%s run_once finished' % self.__class__)

Powered by Google App Engine
This is Rietveld 408576698