client/site_tests/factory_Leds/factory_Leds.py - Issue 3226005: Refactory UI to grab shortcut keys, and tests to not look for triggers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/site_tests/factory_Leds/factory_Leds.py

Issue 3226005: Refactory UI to grab shortcut keys, and tests to not look for triggers. (Closed) Base URL: http://git.chromium.org/git/autotest.git

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « client/site_tests/factory_Keyboard/factory_Keyboard.py ('k') | client/site_tests/factory_LightSensor/factory_LightSensor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: client/site_tests/factory_Leds/factory_Leds.py

diff --git a/client/site_tests/factory_Leds/factory_Leds.py b/client/site_tests/factory_Leds/factory_Leds.py

index f820291e471f232fc620dcaac2b086cf09ae50f8..d31f147c64f41c918d62994fa9996420f5024ede 100644

--- a/client/site_tests/factory_Leds/factory_Leds.py

+++ b/client/site_tests/factory_Leds/factory_Leds.py

@@ -166,23 +166,16 @@ class factory_Leds(test.test):

event.keyval == gtk.keysyms.Shift_L:

self._shift_cnt += 1

self._pattern_da.queue_draw()

- else:

- self._ft_state.exit_on_trigger(event)

return True

def register_callbacks(self, window):

window.connect('key-release-event', self.key_release_callback)

window.add_events(gdk.KEY_RELEASE_MASK)

- def run_once(self,

- test_widget_size=None,

- trigger_set=None,

- led_ctl_path=None):

+ def run_once(self, led_ctl_path=None):

factory.log('%s run_once' % self.__class__)

- self._ft_state = ful.State(trigger_set)

self._led_ctl_path = led_ctl_path

self._shift_color = ful.BLACK

@@ -230,9 +223,7 @@ class factory_Leds(test.test):

self.goto_next_pattern()

- self._ft_state.run_test_widget(

- test_widget=test_widget,

- test_widget_size=test_widget_size,

+ ful.run_test_widget(self.job, test_widget,

window_registration_callback=self.register_callbacks,

cleanup_callback=self.quit)