Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: client/site_tests/factory_Dummy/factory_Dummy.py

Issue 3226005: Refactory UI to grab shortcut keys, and tests to not look for triggers. (Closed) Base URL: http://git.chromium.org/git/autotest.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/site_tests/factory_Dummy/factory_Dummy.py
diff --git a/client/site_tests/factory_Dummy/factory_Dummy.py b/client/site_tests/factory_Dummy/factory_Dummy.py
index fc7049ed9b8631acd7b7054f88360c27b40805f6..da59a3fd24167284c2d051af37f9c035e4411db0 100644
--- a/client/site_tests/factory_Dummy/factory_Dummy.py
+++ b/client/site_tests/factory_Dummy/factory_Dummy.py
@@ -33,7 +33,6 @@ class factory_Dummy(test.test):
factory.log('key_release %s(%s)' % (event.keyval, char))
if event.keyval == self._quit_key:
gtk.main_quit()
- self._ft_state.exit_on_trigger(event)
return True
def register_callbacks(self, window):
@@ -41,8 +40,6 @@ class factory_Dummy(test.test):
window.add_events(gdk.KEY_RELEASE_MASK)
def run_once(self,
- test_widget_size=None,
- trigger_set=None,
quit_key=ord('Q'),
msg='factory_Dummy'):
@@ -50,17 +47,13 @@ class factory_Dummy(test.test):
self._quit_key = quit_key
- self._ft_state = ful.State(trigger_set)
-
label = ful.make_label(msg)
test_widget = gtk.EventBox()
test_widget.modify_bg(gtk.STATE_NORMAL, ful.BLACK)
test_widget.add(label)
- self._ft_state.run_test_widget(
- test_widget=test_widget,
- test_widget_size=test_widget_size,
+ ful.run_test_widget(self.job, test_widget,
window_registration_callback=self.register_callbacks)
- factory.log('%s run_once finished' % self.__class__)
+ factory.log('%s run_once finished' % repr(self.__class__))
« no previous file with comments | « client/site_tests/factory_Display/factory_Display.py ('k') | client/site_tests/factory_ExtDisplay/factory_ExtDisplay.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698