Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3056029: Move the number conversions from string_util to a new file.... (Closed)

Created:
10 years, 4 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, dpranke+watch_chromium.org, John Grabowski, idana, ben+cc_chromium.org, Raghu Simha, Erik does not do reviews, brettw-cc_chromium.org, jam, ncarter (slow), apatrick_chromium, Aaron Boodman, Paul Godavari, darin-cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr., kuchhal, pam+watch_chromium.org, amit, tim (not reviewing)
Visibility:
Public.

Description

Move the number conversions from string_util to a new file. Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54355

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1461 lines, -837 lines) Patch
M app/clipboard/clipboard_win.cc View 1 2 7 chunks +27 lines, -21 lines 0 comments Download
M app/gfx/font_util.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M app/l10n_util.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M app/l10n_util_win.cc View 1 2 3 chunks +8 lines, -3 lines 0 comments Download
M base/base.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M base/file_util_win.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M base/json/json_reader.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M base/json/json_writer.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M base/process_util_linux.cc View 1 2 18 chunks +56 lines, -32 lines 0 comments Download
M base/simple_thread.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/simple_thread_unittest.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
A base/string_number_conversions.h View 1 1 chunk +92 lines, -0 lines 0 comments Download
A base/string_number_conversions.cc View 1 2 1 chunk +400 lines, -0 lines 0 comments Download
A base/string_number_conversions_unittest.cc View 1 2 1 chunk +339 lines, -0 lines 0 comments Download
M base/string_util_unittest.cc View 1 2 2 chunks +0 lines, -367 lines 0 comments Download
M base/version.cc View 1 2 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/app/chrome_dll_main.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/autofill/auto_fill_editor_gtk.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/autofill/credit_card.cc View 1 2 7 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/autofill/form_structure.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/back_forward_menu_model.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.cc View 1 2 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/power_menu_button.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/update_observer.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/cocoa/about_window_controller.mm View 1 2 6 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/cocoa/history_menu_bridge.mm View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/page_info_window_mac_unittest.mm View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/config_dir_policy_provider_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/debugger/debugger_remote_service.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_listen_socket.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_message.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_message_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/debugger/extension_ports_remote_service.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/diagnostics/sqlite_diagnostics.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/net_internals_ui.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/ntp_resource_cache.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/download/drag_download_util.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_bookmark_helpers.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_bookmark_manager_api.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.cc View 1 2 9 chunks +18 lines, -13 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_clipboard_api.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_api.cc View 1 2 5 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_history_api.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_module.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_page_actions_module.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 2 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_updater.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_updater_unittest.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/network_location_request.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/download_in_progress_dialog_gtk.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/gtk/find_bar_gtk.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/net/predictor_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/predictor_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/page_info_model.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/page_state.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/parsers/metadata_parser_filebase.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/parsers/metadata_parser_filebase_unittest.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/login_database_unittest.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/process_info_snapshot_mac.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_sandbox_host_linux.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/chunk_range.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_model.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_add_cert_handler.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/syncer_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/http_bridge.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/syncable/directory_backing_store.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/syncable/syncable.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/util/fast_dump.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/autofill_profiles_view_win.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view_test.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/webdata/web_database_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/wrench_menu_model.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/zygote_host_linux.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/child_process.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/child_process_logging_mac.mm View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/common/child_process_logging_win.cc View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 25 chunks +45 lines, -34 lines 0 comments Download
M chrome/common/extensions/update_manifest.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/important_file_writer.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/logging_chrome.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/metrics_helpers.cc View 1 2 6 chunks +10 lines, -9 lines 0 comments Download
M chrome/common/plugin_messages.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/automation/autocomplete_edit_proxy.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/interactive_ui/view_event_test_base.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/page_cycler/page_cycler_test.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/startup/startup_test.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/sync/engine/test_id_factory.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/ui/npapi_uitest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/ui/ui_layout_test.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/metrics_service.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome_frame/np_proxy_service.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/npapi_url_request.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/urlmon_url_request.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M courgette/ensemble.cc View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M jingle/notifier/listener/xml_element_util.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_auth_cache_unittest.cc View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M net/http/http_cache.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M net/http/http_network_transaction.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M net/http/partial_data.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M net/proxy/proxy_config.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M net/spdy/spdy_session.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M net/test/test_server.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/fetch/http_listen_socket.cc View 1 2 4 chunks +7 lines, -5 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/websockets/websocket_handshake.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M tools/memory_watcher/call_stack.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M tools/memory_watcher/call_stack.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M tools/memory_watcher/memory_watcher.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_disk_cache.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/database/database_tracker.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/dom_operations.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/glue/multipart_response_delegate.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/glue/plugins/pepper_var.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/plugins/plugin_instance.cc View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M webkit/glue/plugins/plugin_list_win.cc View 1 2 3 chunks +8 lines, -5 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_win.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/node_leak_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
10 years, 4 months ago (2010-07-29 17:03:10 UTC) #1
cpu_(ooo_6.6-7.5)
10 years, 4 months ago (2010-07-29 18:41:22 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698