Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2895)

Unified Diff: chrome/common/child_process_logging_mac.mm

Issue 3056029: Move the number conversions from string_util to a new file.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/child_process.cc ('k') | chrome/common/child_process_logging_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/child_process_logging_mac.mm
===================================================================
--- chrome/common/child_process_logging_mac.mm (revision 54340)
+++ chrome/common/child_process_logging_mac.mm (working copy)
@@ -6,7 +6,9 @@
#import <Foundation/Foundation.h>
+#include "base/string_number_conversions.h"
#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
#include "chrome/common/gpu_info.h"
#include "chrome/installer/util/google_update_settings.h"
#include "googleurl/src/gurl.h"
@@ -112,19 +114,19 @@
void SetGpuInfoImpl(const GPUInfo& gpu_info,
SetCrashKeyValueFuncPtr set_key_func) {
SetGpuKeyValue(kGPUVendorIdParamName,
- UintToString(gpu_info.vendor_id()),
+ base::UintToString(gpu_info.vendor_id()),
set_key_func);
SetGpuKeyValue(kGPUDeviceIdParamName,
- UintToString(gpu_info.device_id()),
+ base::UintToString(gpu_info.device_id()),
set_key_func);
SetGpuKeyValue(kGPUDriverVersionParamName,
- WideToASCII(gpu_info.driver_version()),
+ WideToUTF8(gpu_info.driver_version()),
set_key_func);
SetGpuKeyValue(kGPUPixelShaderVersionParamName,
- UintToString(gpu_info.pixel_shader_version()),
+ base::UintToString(gpu_info.pixel_shader_version()),
set_key_func);
SetGpuKeyValue(kGPUVertexShaderVersionParamName,
- UintToString(gpu_info.vertex_shader_version()),
+ base::UintToString(gpu_info.vertex_shader_version()),
set_key_func);
}
« no previous file with comments | « chrome/common/child_process.cc ('k') | chrome/common/child_process_logging_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698