Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Side by Side Diff: chrome/browser/back_forward_menu_model.cc

Issue 3056029: Move the number conversions from string_util to a new file.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 6
7 #include "chrome/browser/back_forward_menu_model.h" 7 #include "chrome/browser/back_forward_menu_model.h"
8 8
9 #include "app/l10n_util.h" 9 #include "app/l10n_util.h"
10 #include "app/resource_bundle.h" 10 #include "app/resource_bundle.h"
11 #include "base/string_number_conversions.h"
11 #include "chrome/browser/browser.h" 12 #include "chrome/browser/browser.h"
12 #include "chrome/browser/metrics/user_metrics.h" 13 #include "chrome/browser/metrics/user_metrics.h"
13 #include "chrome/browser/tab_contents/navigation_controller.h" 14 #include "chrome/browser/tab_contents/navigation_controller.h"
14 #include "chrome/browser/tab_contents/navigation_entry.h" 15 #include "chrome/browser/tab_contents/navigation_entry.h"
15 #include "chrome/browser/tab_contents/tab_contents.h" 16 #include "chrome/browser/tab_contents/tab_contents.h"
16 #include "chrome/common/url_constants.h" 17 #include "chrome/common/url_constants.h"
17 #include "grit/generated_resources.h" 18 #include "grit/generated_resources.h"
18 #include "grit/theme_resources.h" 19 #include "grit/theme_resources.h"
19 #include "net/base/registry_controlled_domain.h" 20 #include "net/base/registry_controlled_domain.h"
20 21
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 DCHECK(!action.empty()); 362 DCHECK(!action.empty());
362 DCHECK(index >= -1); 363 DCHECK(index >= -1);
363 std::string metric_string; 364 std::string metric_string;
364 if (model_type_ == FORWARD_MENU) 365 if (model_type_ == FORWARD_MENU)
365 metric_string += "ForwardMenu_"; 366 metric_string += "ForwardMenu_";
366 else 367 else
367 metric_string += "BackMenu_"; 368 metric_string += "BackMenu_";
368 metric_string += action; 369 metric_string += action;
369 if (index != -1) { 370 if (index != -1) {
370 // +1 is for historical reasons (indices used to start at 1). 371 // +1 is for historical reasons (indices used to start at 1).
371 metric_string += IntToString(index + 1); 372 metric_string += base::IntToString(index + 1);
372 } 373 }
373 return metric_string; 374 return metric_string;
374 } 375 }
OLDNEW
« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/bookmarks/bookmark_codec.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698