Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 3056029: Move the number conversions from string_util to a new file.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module.cc
===================================================================
--- chrome/browser/extensions/extension_tabs_module.cc (revision 54340)
+++ chrome/browser/extensions/extension_tabs_module.cc (working copy)
@@ -5,6 +5,7 @@
#include "chrome/browser/extensions/extension_tabs_module.h"
#include "base/base64.h"
+#include "base/string_number_conversions.h"
#include "base/string_util.h"
#include "chrome/browser/browser.h"
#include "chrome/browser/browser_list.h"
@@ -223,7 +224,7 @@
include_incognito(), &error_);
if (!browser || !browser->window()) {
error_ = ExtensionErrorUtils::FormatErrorMessage(
- keys::kWindowNotFoundError, IntToString(window_id));
+ keys::kWindowNotFoundError, base::IntToString(window_id));
return false;
}
@@ -396,7 +397,7 @@
include_incognito(), &error_);
if (!browser || !browser->window()) {
error_ = ExtensionErrorUtils::FormatErrorMessage(
- keys::kWindowNotFoundError, IntToString(window_id));
+ keys::kWindowNotFoundError, base::IntToString(window_id));
return false;
}
@@ -746,7 +747,7 @@
contents = source_tab_strip->DetachTabContentsAt(tab_index);
if (!contents) {
error_ = ExtensionErrorUtils::FormatErrorMessage(
- keys::kTabNotFoundError, IntToString(tab_id));
+ keys::kTabNotFoundError, base::IntToString(tab_id));
return false;
}
@@ -1060,7 +1061,7 @@
if (error_message)
*error_message = ExtensionErrorUtils::FormatErrorMessage(
- keys::kWindowNotFoundError, IntToString(window_id));
+ keys::kWindowNotFoundError, base::IntToString(window_id));
return NULL;
}
@@ -1078,7 +1079,7 @@
if (error_message)
*error_message = ExtensionErrorUtils::FormatErrorMessage(
- keys::kTabNotFoundError, IntToString(tab_id));
+ keys::kTabNotFoundError, base::IntToString(tab_id));
return false;
}
« no previous file with comments | « chrome/browser/extensions/extension_prefs_unittest.cc ('k') | chrome/browser/extensions/extension_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698