Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5754)

Unified Diff: chrome/browser/extensions/extension_context_menu_api.cc

Issue 3056029: Move the number conversions from string_util to a new file.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_context_menu_api.cc
===================================================================
--- chrome/browser/extensions/extension_context_menu_api.cc (revision 54340)
+++ chrome/browser/extensions/extension_context_menu_api.cc (working copy)
@@ -7,6 +7,7 @@
#include <string>
#include "base/values.h"
+#include "base/string_number_conversions.h"
#include "base/string_util.h"
#include "chrome/browser/extensions/extensions_service.h"
#include "chrome/browser/profile.h"
@@ -188,7 +189,8 @@
ExtensionMenuItem* parent = manager.GetItemById(parent_id);
if (!parent) {
- error_ = "Cannot find menu item with id " + IntToString(parent_id.second);
+ error_ = "Cannot find menu item with id " +
+ base::IntToString(parent_id.second);
return false;
}
if (parent->type() != ExtensionMenuItem::NORMAL) {
@@ -246,7 +248,7 @@
ExtensionMenuItem* parent = menu_manager->GetItemById(parent_id);
if (!parent) {
error_ = ExtensionErrorUtils::FormatErrorMessage(
- kCannotFindItemError, IntToString(parent_id.second));
+ kCannotFindItemError, base::IntToString(parent_id.second));
return false;
}
if (parent->type() != ExtensionMenuItem::NORMAL) {
@@ -273,7 +275,7 @@
ExtensionMenuItem* item = manager->GetItemById(item_id);
if (!item || item->extension_id() != extension_id()) {
error_ = ExtensionErrorUtils::FormatErrorMessage(
- kCannotFindItemError, IntToString(item_id.second));
+ kCannotFindItemError, base::IntToString(item_id.second));
return false;
}
@@ -341,7 +343,7 @@
// Ensure one extension can't remove another's menu items.
if (!item || item->extension_id() != extension_id()) {
error_ = ExtensionErrorUtils::FormatErrorMessage(
- kCannotFindItemError, IntToString(id.second));
+ kCannotFindItemError, base::IntToString(id.second));
return false;
}
« no previous file with comments | « chrome/browser/extensions/extension_clipboard_api.cc ('k') | chrome/browser/extensions/extension_history_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698