Issue 3033050: Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3033050: Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload). (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Visibility:
Public.

Description

Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload). Also do a bunch of drive-by changes while I'm at it. Still to do: rename GetStringAsUTF16() to GetString(). BUG=none TEST=builds everywhere, tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54915

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+392 lines, -391 lines)			Patch
M	base/values.h	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	base/values.cc	View		2 chunks	+7 lines, -5 lines	0 comments	Download
M	base/values_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View	1 2	48 chunks	+158 lines, -153 lines	0 comments	Download
M	chrome/browser/automation/automation_provider_observers.cc	View		6 chunks	+31 lines, -34 lines	0 comments	Download
M	chrome/browser/background_contents_service.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_codec.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui.cc	View		3 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/dom_ui/history2_ui.cc	View		3 chunks	+44 lines, -44 lines	0 comments	Download
M	chrome/browser/dom_ui/history_ui.cc	View		3 chunks	+44 lines, -44 lines	0 comments	Download
M	chrome/browser/dom_ui/net_internals_ui.cc	View		10 chunks	+40 lines, -43 lines	0 comments	Download
M	chrome/browser/extensions/extension_history_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/geolocation/network_location_request.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugin_updater.cc	View		3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/common/plugin_group.cc	View		4 chunks	+22 lines, -23 lines	0 comments	Download
M	chrome/renderer/blocked_plugin.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/localized_error.cc	View		6 chunks	+16 lines, -16 lines	0 comments	Download
M	net/proxy/proxy_resolver_js_bindings.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 3033050: Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload). (Closed)

Description

Patch Set 1 #

Patch Set 2 : merge ToT #

Patch Set 3 : There shouldn't be wstrings in platform-ind. code. #

Messages