chrome/browser/geolocation/network_location_request.cc - Issue 3033050: Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/network_location_request.cc

Issue 3033050: Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload). (Closed)

Patch Set: There shouldn't be wstrings in platform-ind. code. Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/geolocation/network_location_request.cc

diff --git a/chrome/browser/geolocation/network_location_request.cc b/chrome/browser/geolocation/network_location_request.cc

index d6a4f33e46e51e44b78b91c73da73dbefd6fa52a..e6423b02425d8a80fdc56c27930102159d5d4371 100644

--- a/chrome/browser/geolocation/network_location_request.cc

+++ b/chrome/browser/geolocation/network_location_request.cc

@@ -244,7 +244,7 @@ void AddString(const std::wstring& property_name,

DictionaryValue* object) {

DCHECK(object);

if (!value.empty()) {

- object->SetStringFromUTF16(property_name, value);

+ object->SetString(property_name, value);

}

« no previous file with comments | « chrome/browser/extensions/extension_history_api.cc ('k') | chrome/browser/plugin_updater.cc » ('j') | no next file with comments »