chrome/renderer/blocked_plugin.cc - Issue 3033050: Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/blocked_plugin.cc

Issue 3033050: Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload). (Closed)

Patch Set: There shouldn't be wstrings in platform-ind. code. Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/blocked_plugin.cc

diff --git a/chrome/renderer/blocked_plugin.cc b/chrome/renderer/blocked_plugin.cc

index a6ef499ff0963b84456cb0e04ffcf7837fdba478..906726f7d2ab6c8d7b23d9bc0b8c1f2e2c6e9459 100644

--- a/chrome/renderer/blocked_plugin.cc

+++ b/chrome/renderer/blocked_plugin.cc

@@ -49,8 +49,8 @@ BlockedPlugin::BlockedPlugin(RenderView* render_view,

<< resource_id;

DictionaryValue localized_strings;

- localized_strings.SetStringFromUTF16("loadPlugin",

- l10n_util::GetStringUTF16(IDS_PLUGIN_LOAD));

+ localized_strings.SetString("loadPlugin",

+ l10n_util::GetStringUTF16(IDS_PLUGIN_LOAD));

// "t" is the id of the templates root node.

std::string htmlData = jstemplate_builder::GetTemplatesHtml(

« no previous file with comments | « chrome/common/plugin_group.cc ('k') | chrome/renderer/localized_error.cc » ('j') | no next file with comments »