base/values_unittest.cc - Issue 3033050: Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values_unittest.cc

Issue 3033050: Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload). (Closed)

Patch Set: There shouldn't be wstrings in platform-ind. code. Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values_unittest.cc

diff --git a/base/values_unittest.cc b/base/values_unittest.cc

index fb414c1776e82204a147c1db28c2b897d7e8ac53..7971e128c3d1a879682f42e87ded96dac9051b70 100644

--- a/base/values_unittest.cc

+++ b/base/values_unittest.cc

@@ -784,7 +784,7 @@ TEST(ValuesTest, Equals) {

dv.SetInteger("b", 2);

dv.SetReal("c", 2.5);

dv.SetString("d1", "string");

- dv.SetStringFromUTF16("d2", ASCIIToUTF16("http://google.com"));

+ dv.SetString("d2", ASCIIToUTF16("http://google.com"));

dv.Set("e", Value::CreateNullValue());

DictionaryValue* copy = static_cast<DictionaryValue*>(dv.DeepCopy());

« no previous file with comments | « base/values.cc ('k') | chrome/browser/automation/automation_provider.cc » ('j') | no next file with comments »