chrome/browser/extensions/extension_history_api.cc - Issue 3033050: Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_history_api.cc

Issue 3033050: Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload). (Closed)

Patch Set: There shouldn't be wstrings in platform-ind. code. Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_history_api.cc

diff --git a/chrome/browser/extensions/extension_history_api.cc b/chrome/browser/extensions/extension_history_api.cc

index 0b891c81540d94b6cfbc14593093b8fe41a7f87e..6261a4bf36cd3e02d32844be3d35ac0898aefcbe 100644

--- a/chrome/browser/extensions/extension_history_api.cc

+++ b/chrome/browser/extensions/extension_history_api.cc

@@ -30,7 +30,7 @@ void GetHistoryItemDictionary(const history::URLRow& row,

DictionaryValue* value) {

value->SetString(keys::kIdKey, base::Int64ToString(row.id()));

value->SetString(keys::kUrlKey, row.url().spec());

- value->SetStringFromUTF16(keys::kTitleKey, row.title());

+ value->SetString(keys::kTitleKey, row.title());

value->SetReal(keys::kLastVisitdKey, MilliSecondsFromTime(row.last_visit()));

value->SetInteger(keys::kTypedCountKey, row.typed_count());

value->SetInteger(keys::kVisitCountKey, row.visit_count());