Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2920004: Nukes the import parameters to ShowAutoFillDialog as they aren't used. (Closed)

Created:
10 years, 5 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Nukes the import parameters to ShowAutoFillDialog as they aren't used. BUG=44620 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51973

Patch Set 1 #

Total comments: 2

Patch Set 2 : added todos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -35 lines) Patch
M chrome/browser/autofill/autofill_dialog.h View 1 chunk +1 line, -12 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_gtk.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_mac.mm View 1 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/content_page_gtk.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/views/autofill_profiles_view_win.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/views/options/content_page_view.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
10 years, 5 months ago (2010-07-08 21:18:16 UTC) #1
James Hawkins
http://codereview.chromium.org/2920004/diff/1/3 File chrome/browser/autofill/autofill_dialog_gtk.cc (right): http://codereview.chromium.org/2920004/diff/1/3#newcode232 chrome/browser/autofill/autofill_dialog_gtk.cc:232: AutoFillProfile* imported_profile, If it's easy to remove these, please ...
10 years, 5 months ago (2010-07-08 21:30:26 UTC) #2
sky
http://codereview.chromium.org/2920004/diff/1/3 File chrome/browser/autofill/autofill_dialog_gtk.cc (right): http://codereview.chromium.org/2920004/diff/1/3#newcode232 chrome/browser/autofill/autofill_dialog_gtk.cc:232: AutoFillProfile* imported_profile, On 2010/07/08 21:30:27, James Hawkins wrote: > ...
10 years, 5 months ago (2010-07-08 21:53:29 UTC) #3
James Hawkins
10 years, 5 months ago (2010-07-08 21:56:56 UTC) #4
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698