Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: chrome/browser/views/autofill_profiles_view_win.cc

Issue 2920004: Nukes the import parameters to ShowAutoFillDialog as they aren't used. (Closed)
Patch Set: added todos Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 #include "chrome/browser/views/autofill_profiles_view_win.h" 4 #include "chrome/browser/views/autofill_profiles_view_win.h"
5 5
6 #include <vsstyle.h> 6 #include <vsstyle.h>
7 #include <vssym32.h> 7 #include <vssym32.h>
8 8
9 #include "app/l10n_util.h" 9 #include "app/l10n_util.h"
10 #include "app/resource_bundle.h" 10 #include "app/resource_bundle.h"
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 AutoFillProfilesView::~AutoFillProfilesView() { 87 AutoFillProfilesView::~AutoFillProfilesView() {
88 // Clear model as it gets deleted before the view. 88 // Clear model as it gets deleted before the view.
89 if (scroll_view_) 89 if (scroll_view_)
90 scroll_view_->SetModel(NULL); 90 scroll_view_->SetModel(NULL);
91 91
92 // Removes observer if we are observing Profile load. Does nothing otherwise. 92 // Removes observer if we are observing Profile load. Does nothing otherwise.
93 if (personal_data_manager_) 93 if (personal_data_manager_)
94 personal_data_manager_->RemoveObserver(this); 94 personal_data_manager_->RemoveObserver(this);
95 } 95 }
96 96
97 // TODO: get rid of imported_profile and imported_credit_card.
97 int AutoFillProfilesView::Show(gfx::NativeWindow parent, 98 int AutoFillProfilesView::Show(gfx::NativeWindow parent,
98 AutoFillDialogObserver* observer, 99 AutoFillDialogObserver* observer,
99 PersonalDataManager* personal_data_manager, 100 PersonalDataManager* personal_data_manager,
100 PrefService* preferences, 101 PrefService* preferences,
101 AutoFillProfile* imported_profile, 102 AutoFillProfile* imported_profile,
102 CreditCard* imported_credit_card) { 103 CreditCard* imported_credit_card) {
103 if (!instance_) { 104 if (!instance_) {
104 instance_ = new AutoFillProfilesView(observer, personal_data_manager, 105 instance_ = new AutoFillProfilesView(observer, personal_data_manager,
105 preferences, imported_profile, imported_credit_card); 106 preferences, imported_profile, imported_credit_card);
106 107
(...skipping 1251 matching lines...) Expand 10 before | Expand all | Expand 10 after
1358 1359
1359 void AutoFillProfilesView::ContentListTableModel::SetObserver( 1360 void AutoFillProfilesView::ContentListTableModel::SetObserver(
1360 TableModelObserver* observer) { 1361 TableModelObserver* observer) {
1361 observer_ = observer; 1362 observer_ = observer;
1362 } 1363 }
1363 1364
1364 1365
1365 // Declared in "chrome/browser/autofill/autofill_dialog.h" 1366 // Declared in "chrome/browser/autofill/autofill_dialog.h"
1366 void ShowAutoFillDialog(gfx::NativeView parent, 1367 void ShowAutoFillDialog(gfx::NativeView parent,
1367 AutoFillDialogObserver* observer, 1368 AutoFillDialogObserver* observer,
1368 Profile* profile, 1369 Profile* profile) {
1369 AutoFillProfile* imported_profile,
1370 CreditCard* imported_credit_card) {
1371 DCHECK(profile); 1370 DCHECK(profile);
1372 1371
1373 PersonalDataManager* personal_data_manager = 1372 PersonalDataManager* personal_data_manager =
1374 profile->GetPersonalDataManager(); 1373 profile->GetPersonalDataManager();
1375 DCHECK(personal_data_manager); 1374 DCHECK(personal_data_manager);
1376 AutoFillProfilesView::Show(parent, observer, personal_data_manager, 1375 AutoFillProfilesView::Show(parent, observer, personal_data_manager,
1377 profile->GetPrefs(), imported_profile, imported_credit_card); 1376 profile->GetPrefs(), NULL, NULL);
1378 } 1377 }
OLDNEW
« no previous file with comments | « chrome/browser/gtk/options/content_page_gtk.cc ('k') | chrome/browser/views/options/content_page_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698