Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/browser/autofill/autofill_manager.cc

Issue 2920004: Nukes the import parameters to ShowAutoFillDialog as they aren't used. (Closed)
Patch Set: added todos Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/autofill/autofill_manager.h" 5 #include "chrome/browser/autofill/autofill_manager.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/string16.h" 10 #include "base/string16.h"
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
332 ++i; 332 ++i;
333 } 333 }
334 334
335 host->AutoFillFormDataFilled(query_id, result); 335 host->AutoFillFormDataFilled(query_id, result);
336 return true; 336 return true;
337 } 337 }
338 338
339 void AutoFillManager::ShowAutoFillDialog() { 339 void AutoFillManager::ShowAutoFillDialog() {
340 ::ShowAutoFillDialog(tab_contents_->GetContentNativeView(), 340 ::ShowAutoFillDialog(tab_contents_->GetContentNativeView(),
341 personal_data_, 341 personal_data_,
342 tab_contents_->profile()->GetOriginalProfile(), 342 tab_contents_->profile()->GetOriginalProfile());
343 NULL,
344 NULL);
345 } 343 }
346 344
347 void AutoFillManager::Reset() { 345 void AutoFillManager::Reset() {
348 upload_form_structure_.reset(); 346 upload_form_structure_.reset();
349 form_structures_.reset(); 347 form_structures_.reset();
350 } 348 }
351 349
352 void AutoFillManager::OnLoadedAutoFillHeuristics( 350 void AutoFillManager::OnLoadedAutoFillHeuristics(
353 const std::string& heuristic_xml) { 351 const std::string& heuristic_xml) {
354 // TODO(jhawkins): Store |upload_required| in the AutoFillManager. 352 // TODO(jhawkins): Store |upload_required| in the AutoFillManager.
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 field->set_value(number); 595 field->set_value(number);
598 } else if (has_valid_suffix_and_prefix && 596 } else if (has_valid_suffix_and_prefix &&
599 field->size() == kAutoFillPhoneNumberSuffixCount) { 597 field->size() == kAutoFillPhoneNumberSuffixCount) {
600 number = number.substr(kAutoFillPhoneNumberSuffixOffset, 598 number = number.substr(kAutoFillPhoneNumberSuffixOffset,
601 kAutoFillPhoneNumberSuffixCount); 599 kAutoFillPhoneNumberSuffixCount);
602 field->set_value(number); 600 field->set_value(number);
603 } else { 601 } else {
604 field->set_value(number); 602 field->set_value(number);
605 } 603 }
606 } 604 }
OLDNEW
« no previous file with comments | « chrome/browser/autofill/autofill_dialog_mac.mm ('k') | chrome/browser/cocoa/preferences_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698