Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: chrome/browser/views/options/content_page_view.cc

Issue 2920004: Nukes the import parameters to ShowAutoFillDialog as they aren't used. (Closed)
Patch Set: added todos Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/views/autofill_profiles_view_win.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/views/options/content_page_view.h" 5 #include "chrome/browser/views/options/content_page_view.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <shlobj.h> 8 #include <shlobj.h>
9 #include <vsstyle.h> 9 #include <vsstyle.h>
10 #include <vssym32.h> 10 #include <vssym32.h>
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 ask_to_save_form_autofill_.SetValue(enabled); 117 ask_to_save_form_autofill_.SetValue(enabled);
118 } else if (sender == show_passwords_button_) { 118 } else if (sender == show_passwords_button_) {
119 UserMetricsRecordAction( 119 UserMetricsRecordAction(
120 UserMetricsAction("Options_ShowPasswordsExceptions"), NULL); 120 UserMetricsAction("Options_ShowPasswordsExceptions"), NULL);
121 PasswordsExceptionsWindowView::Show(profile()); 121 PasswordsExceptionsWindowView::Show(profile());
122 } else if (sender == change_autofill_settings_button_) { 122 } else if (sender == change_autofill_settings_button_) {
123 // This button should be disabled if we lack PersonalDataManager. 123 // This button should be disabled if we lack PersonalDataManager.
124 DCHECK(profile()->GetPersonalDataManager()); 124 DCHECK(profile()->GetPersonalDataManager());
125 ShowAutoFillDialog(GetWindow()->GetNativeWindow(), 125 ShowAutoFillDialog(GetWindow()->GetNativeWindow(),
126 profile()->GetPersonalDataManager(), 126 profile()->GetPersonalDataManager(),
127 profile(), 127 profile());
128 NULL,
129 NULL);
130 } else if (sender == themes_reset_button_) { 128 } else if (sender == themes_reset_button_) {
131 UserMetricsRecordAction(UserMetricsAction("Options_ThemesReset"), 129 UserMetricsRecordAction(UserMetricsAction("Options_ThemesReset"),
132 profile()->GetPrefs()); 130 profile()->GetPrefs());
133 profile()->ClearTheme(); 131 profile()->ClearTheme();
134 } else if (sender == import_button_) { 132 } else if (sender == import_button_) {
135 views::Window::CreateChromeWindow( 133 views::Window::CreateChromeWindow(
136 GetWindow()->GetNativeWindow(), 134 GetWindow()->GetNativeWindow(),
137 gfx::Rect(), 135 gfx::Rect(),
138 new ImporterView(profile(), importer::ALL))->Show(); 136 new ImporterView(profile(), importer::ALL))->Show();
139 } else if (sender == sync_start_stop_button_) { 137 } else if (sender == sync_start_stop_button_) {
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
493 sync_action_link_->SetVisible(!link_label.empty()); 491 sync_action_link_->SetVisible(!link_label.empty());
494 492
495 if (status_has_error) { 493 if (status_has_error) {
496 sync_status_label_->set_background(CreateErrorBackground()); 494 sync_status_label_->set_background(CreateErrorBackground());
497 sync_action_link_->set_background(CreateErrorBackground()); 495 sync_action_link_->set_background(CreateErrorBackground());
498 } else { 496 } else {
499 sync_status_label_->set_background(NULL); 497 sync_status_label_->set_background(NULL);
500 sync_action_link_->set_background(NULL); 498 sync_action_link_->set_background(NULL);
501 } 499 }
502 } 500 }
OLDNEW
« no previous file with comments | « chrome/browser/views/autofill_profiles_view_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698