Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: chrome/browser/gtk/options/content_page_gtk.cc

Issue 2920004: Nukes the import parameters to ShowAutoFillDialog as they aren't used. (Closed)
Patch Set: added todos Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/gtk/options/content_page_gtk.h" 5 #include "chrome/browser/gtk/options/content_page_gtk.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "app/gtk_util.h" 9 #include "app/gtk_util.h"
10 #include "app/l10n_util.h" 10 #include "app/l10n_util.h"
(...skipping 437 matching lines...) Expand 10 before | Expand all | Expand 10 after
448 #endif 448 #endif
449 } else { 449 } else {
450 gtk_widget_modify_bg(sync_status_label_background_, GTK_STATE_NORMAL, NULL); 450 gtk_widget_modify_bg(sync_status_label_background_, GTK_STATE_NORMAL, NULL);
451 #if !defined(OS_CHROMEOS) 451 #if !defined(OS_CHROMEOS)
452 gtk_widget_modify_bg(sync_action_link_background_, GTK_STATE_NORMAL, NULL); 452 gtk_widget_modify_bg(sync_action_link_background_, GTK_STATE_NORMAL, NULL);
453 #endif 453 #endif
454 } 454 }
455 } 455 }
456 456
457 void ContentPageGtk::OnAutoFillButtonClicked(GtkWidget* widget) { 457 void ContentPageGtk::OnAutoFillButtonClicked(GtkWidget* widget) {
458 ShowAutoFillDialog( 458 ShowAutoFillDialog(NULL, profile()->GetPersonalDataManager(), profile());
459 NULL, profile()->GetPersonalDataManager(), profile(), NULL, NULL);
460 } 459 }
461 460
462 void ContentPageGtk::OnImportButtonClicked(GtkWidget* widget) { 461 void ContentPageGtk::OnImportButtonClicked(GtkWidget* widget) {
463 ImportDialogGtk::Show( 462 ImportDialogGtk::Show(
464 GTK_WINDOW(gtk_widget_get_toplevel(widget)), 463 GTK_WINDOW(gtk_widget_get_toplevel(widget)),
465 profile(), importer::ALL); 464 profile(), importer::ALL);
466 } 465 }
467 466
468 void ContentPageGtk::OnGtkThemeButtonClicked(GtkWidget* widget) { 467 void ContentPageGtk::OnGtkThemeButtonClicked(GtkWidget* widget) {
469 UserMetricsRecordAction(UserMetricsAction("Options_GtkThemeSet"), 468 UserMetricsRecordAction(UserMetricsAction("Options_GtkThemeSet"),
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 sync_service_->ShowLoginDialog(); 611 sync_service_->ShowLoginDialog();
613 } 612 }
614 613
615 void ContentPageGtk::OnStopSyncDialogResponse(GtkWidget* widget, int response) { 614 void ContentPageGtk::OnStopSyncDialogResponse(GtkWidget* widget, int response) {
616 if (response == GTK_RESPONSE_ACCEPT) { 615 if (response == GTK_RESPONSE_ACCEPT) {
617 sync_service_->DisableForUser(); 616 sync_service_->DisableForUser();
618 ProfileSyncService::SyncEvent(ProfileSyncService::STOP_FROM_OPTIONS); 617 ProfileSyncService::SyncEvent(ProfileSyncService::STOP_FROM_OPTIONS);
619 } 618 }
620 gtk_widget_destroy(widget); 619 gtk_widget_destroy(widget);
621 } 620 }
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/preferences_window_controller.mm ('k') | chrome/browser/views/autofill_profiles_view_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698