Issue 2830027: Remove extended attributes. The lame broken codepath in the DBS was causing

Issue 2830027: Remove extended attributes. The lame broken codepath in the DBS was causing (Closed)

Created:
10 years, 6 months ago by ncarter (slow)

Modified:
9 years, 7 months ago

Reviewers:
chron_chromium.org

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, tim (not reviewing), idana, ncarter (slow)

Visibility:
Public.

Description

Remove extended attributes. The lame broken codepath in the DBS was causing several tests to fail their SaveChanges()es. Add unit test for the DBS migrations. BUG=47466 TEST=sync_unit_tests (and included new tests). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51225

Patch Set 1 #

Patch Set 2 : Self review fixes. #

Patch Set 3 : Deprecate the protobuf field, too. #

Patch Set 4 : Deprecate the protobuf field, too. #

Patch Set 5 : Rebase #

Patch Set 6 : Fix linux compile issue #

Patch Set 7 : Synced with TOT, resolved conflicts. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+183 lines, -519 lines)			Patch
M	chrome/browser/sync/engine/build_commit_command.cc	View		2 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_unittest.cc	View	1 2 3 4 5	6 chunks	+0 lines, -64 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_util.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_util.cc	View		3 chunks	+0 lines, -24 lines	0 comments	Download
M	chrome/browser/sync/protocol/sync.proto	View		2 chunks	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/sync/syncable/directory_backing_store.h	View	1 2 3 4 5 6	6 chunks	+4 lines, -12 lines	0 comments	Download
M	chrome/browser/sync/syncable/directory_backing_store.cc	View	1 2 3 4 5 6	12 chunks	+15 lines, -103 lines	0 comments	Download
M	chrome/browser/sync/syncable/directory_backing_store_unittest.cc	View	1 2 3 4 5 6	6 chunks	+138 lines, -1 line	0 comments	Download
M	chrome/browser/sync/syncable/syncable.h	View	1 2 3 4 5 6	8 chunks	+0 lines, -89 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable.cc	View	1 2 3 4 5 6	10 chunks	+1 line, -134 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable_unittest.cc	View	1 2 3 4 5 6	6 chunks	+22 lines, -43 lines	0 comments	Download
M	chrome/test/sync/engine/mock_connection_manager.h	View	3	2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/test/sync/engine/mock_connection_manager.cc	View	3	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

On 2010/06/25 01:56:10, ncarter wrote: > Hi chron, > > Please review. Ping.

10 years, 6 months ago (2010-06-28 01:30:49 UTC) #2

chron

Will do first thing tomorrow On Jun 27, 2010, at 6:30 PM, nick@chromium.org wrote: > ...

10 years, 6 months ago (2010-06-28 06:02:50 UTC) #3

chron_chromium.org

10 years, 5 months ago (2010-06-28 20:50:00 UTC) #4

LGTM

Thanks for the cleanup.

On Sun, Jun 27, 2010 at 11:07 PM, Chron <chron@google.com> wrote:

> Will do first thing tomorrow
>
> On Jun 27, 2010, at 6:30 PM, nick@chromium.org wrote:
>
> > On 2010/06/25 01:56:10, ncarter wrote:
> >> Hi chron,
> >
> >> Please review.
> >
> > Ping.
> >
> > http://codereview.chromium.org/2830027/show
>

Expand Messages | Collapse Messages