Remove extended attributes. The lame broken codepath in the DBS was causing

chrome/browser/sync/engine/build_commit_command.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/build_commit_command.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "chrome/browser/sync/engine/syncer_proto_util.h"
 #include "chrome/browser/sync/engine/syncer_util.h"
 #include "chrome/browser/sync/protocol/bookmark_specifics.pb.h"
 #include "chrome/browser/sync/sessions/sync_session.h"
 #include "chrome/browser/sync/syncable/syncable.h"
 #include "chrome/browser/sync/syncable/syncable_changes_version.h"
 #include "chrome/browser/sync/util/sync_types.h"
 
 using std::set;
 using std::string;
 using std::vector;
-using syncable::ExtendedAttribute;
 using syncable::IS_DEL;
 using syncable::Id;
 using syncable::MutableEntry;
 using syncable::SPECIFICS;
 using syncable::UNSPECIFIED;
 
 namespace browser_sync {
 
 using sessions::SyncSession;
 
@@ skipping 123 matching lines @@
       sync_entry->set_version(0);
     } else {
       CHECK(id.ServerKnows()) << meta_entry;
       sync_entry->set_version(meta_entry.Get(syncable::BASE_VERSION));
     }
     sync_entry->set_ctime(ClientTimeToServerTime(
         meta_entry.Get(syncable::CTIME)));
     sync_entry->set_mtime(ClientTimeToServerTime(
         meta_entry.Get(syncable::MTIME)));
 
-    set<ExtendedAttribute> extended_attributes;
-    meta_entry.GetAllExtendedAttributes(
-        session->write_transaction(), &extended_attributes);
-    set<ExtendedAttribute>::iterator iter;
-    sync_pb::ExtendedAttributes* mutable_extended_attributes =
-        sync_entry->mutable_extended_attributes();
-    for (iter = extended_attributes.begin(); iter != extended_attributes.end();
-        ++iter) {
-      sync_pb::ExtendedAttributes_ExtendedAttribute *extended_attribute =
-          mutable_extended_attributes->add_extendedattribute();
-      extended_attribute->set_key(iter->key());
-      SyncerProtoUtil::CopyBlobIntoProtoBytes(iter->value(),
-          extended_attribute->mutable_value());
-    }
-
     // Deletion is final on the server, let's move things and then delete them.
     if (meta_entry.Get(IS_DEL)) {
       sync_entry->set_deleted(true);
     } else {
       if (meta_entry.Get(SPECIFICS).HasExtension(sync_pb::bookmark)) {
         // Common data in both new and old protocol.
         const Id& prev_id = meta_entry.Get(syncable::PREV_ID);
         string prev_id_string =
             prev_id.IsRoot() ? string() : prev_id.GetServerId();
         sync_entry->set_insert_after_item_id(prev_id_string);
 
         // TODO(ncarter): In practice we won't want to send this data twice
         // over the wire; instead, when deployed servers are able to accept
         // the new-style scheme, we should abandon the old way.
         SetOldStyleBookmarkData(&meta_entry, sync_entry);
       }
       SetEntrySpecifics(&meta_entry, sync_entry);
     }
   }
   session->status_controller()->mutable_commit_message()->CopyFrom(message);
 }
 
 }  // namespace browser_sync