Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: chrome/browser/sync/protocol/sync.proto

Issue 2830027: Remove extended attributes. The lame broken codepath in the DBS was causing (Closed)
Patch Set: Synced with TOT, resolved conflicts. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/engine/syncer_util.cc ('k') | chrome/browser/sync/syncable/directory_backing_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/protocol/sync.proto
diff --git a/chrome/browser/sync/protocol/sync.proto b/chrome/browser/sync/protocol/sync.proto
index 2ca8b4c359a1cc08f6be2a1cb3c9a5208211c8ab..9b3b4d3176ce39ed2976a7a045110aad83874924 100644
--- a/chrome/browser/sync/protocol/sync.proto
+++ b/chrome/browser/sync/protocol/sync.proto
@@ -10,15 +10,6 @@ option optimize_for = LITE_RUNTIME;
package sync_pb;
-// Used to store and send extended attributes, which are arbitrary
-// key value pairs.
-message ExtendedAttributes {
- repeated group ExtendedAttribute = 1 {
- required string key = 2;
- required bytes value = 3;
- }
-}
-
// Used for inspecting how long we spent performing operations in different
// backends. All times must be in millis.
message ProfilingData {
@@ -180,7 +171,8 @@ message SyncEntity {
// Arbitrary key/value pairs associated with this item.
// Present in both GetUpdatesResponse and CommitMessage.
- optional ExtendedAttributes extended_attributes = 17;
+ // Deprecated.
+ // optional ExtendedAttributes extended_attributes = 17;
// If true, indicates that this item has been (or should be) deleted.
// Present in both GetUpdatesResponse and CommitMessage.
« no previous file with comments | « chrome/browser/sync/engine/syncer_util.cc ('k') | chrome/browser/sync/syncable/directory_backing_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698