Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/browser/sync/engine/build_commit_command.cc

Issue 2830027: Remove extended attributes. The lame broken codepath in the DBS was causing (Closed)
Patch Set: Synced with TOT, resolved conflicts. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/engine/syncer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/build_commit_command.cc
diff --git a/chrome/browser/sync/engine/build_commit_command.cc b/chrome/browser/sync/engine/build_commit_command.cc
index a697c699345a8ad7a192c0681c964c176b552911..49f5f25b3a63bdf6dacc4451e4d1ccd20a9d49b9 100644
--- a/chrome/browser/sync/engine/build_commit_command.cc
+++ b/chrome/browser/sync/engine/build_commit_command.cc
@@ -19,7 +19,6 @@
using std::set;
using std::string;
using std::vector;
-using syncable::ExtendedAttribute;
using syncable::IS_DEL;
using syncable::Id;
using syncable::MutableEntry;
@@ -163,21 +162,6 @@ void BuildCommitCommand::ExecuteImpl(SyncSession* session) {
sync_entry->set_mtime(ClientTimeToServerTime(
meta_entry.Get(syncable::MTIME)));
- set<ExtendedAttribute> extended_attributes;
- meta_entry.GetAllExtendedAttributes(
- session->write_transaction(), &extended_attributes);
- set<ExtendedAttribute>::iterator iter;
- sync_pb::ExtendedAttributes* mutable_extended_attributes =
- sync_entry->mutable_extended_attributes();
- for (iter = extended_attributes.begin(); iter != extended_attributes.end();
- ++iter) {
- sync_pb::ExtendedAttributes_ExtendedAttribute *extended_attribute =
- mutable_extended_attributes->add_extendedattribute();
- extended_attribute->set_key(iter->key());
- SyncerProtoUtil::CopyBlobIntoProtoBytes(iter->value(),
- extended_attribute->mutable_value());
- }
-
// Deletion is final on the server, let's move things and then delete them.
if (meta_entry.Get(IS_DEL)) {
sync_entry->set_deleted(true);
« no previous file with comments | « no previous file | chrome/browser/sync/engine/syncer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698