Remove extended attributes. The lame broken codepath in the DBS was causing

chrome/browser/sync/engine/syncer_util.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/syncer_util.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
@@ skipping 12 matching lines @@
 
 using syncable::BASE_VERSION;
 using syncable::Blob;
 using syncable::CHANGES_VERSION;
 using syncable::CREATE;
 using syncable::CREATE_NEW_UPDATE_ITEM;
 using syncable::CTIME;
 using syncable::ComparePathNames;
 using syncable::Directory;
 using syncable::Entry;
-using syncable::ExtendedAttributeKey;
 using syncable::GET_BY_HANDLE;
 using syncable::GET_BY_ID;
 using syncable::ID;
 using syncable::IS_DEL;
 using syncable::IS_DIR;
 using syncable::IS_UNAPPLIED_UPDATE;
 using syncable::IS_UNSYNCED;
 using syncable::Id;
 using syncable::META_HANDLE;
 using syncable::MTIME;
 using syncable::MutableEntry;
-using syncable::MutableExtendedAttribute;
 using syncable::NEXT_ID;
 using syncable::NON_UNIQUE_NAME;
 using syncable::PARENT_ID;
 using syncable::PREV_ID;
 using syncable::ReadTransaction;
 using syncable::SERVER_CTIME;
 using syncable::SERVER_IS_DEL;
 using syncable::SERVER_IS_DIR;
 using syncable::SERVER_MTIME;
 using syncable::SERVER_NON_UNIQUE_NAME;
@@ skipping 344 matching lines @@
                      server_entry.position_in_parent());
   }
 
   local_entry->Put(SERVER_IS_DEL, server_entry.deleted());
   // We only mark the entry as unapplied if its version is greater than the
   // local data. If we're processing the update that corresponds to one of our
   // commit we don't apply it as time differences may occur.
   if (server_entry.version() > local_entry->Get(BASE_VERSION)) {
     local_entry->Put(IS_UNAPPLIED_UPDATE, true);
   }
-  ApplyExtendedAttributes(local_entry, server_entry);
-}
-
-// static
-void SyncerUtil::ApplyExtendedAttributes(
-    syncable::MutableEntry* local_entry,
-    const SyncEntity& server_entry) {
-  local_entry->DeleteAllExtendedAttributes(local_entry->write_transaction());
-  if (server_entry.has_extended_attributes()) {
-    const sync_pb::ExtendedAttributes & extended_attributes =
-      server_entry.extended_attributes();
-    for (int i = 0; i < extended_attributes.extendedattribute_size(); i++) {
-      const string& string_key =
-          extended_attributes.extendedattribute(i).key();
-      ExtendedAttributeKey key(local_entry->Get(META_HANDLE), string_key);
-      MutableExtendedAttribute local_attribute(local_entry->write_transaction(),
-          CREATE, key);
-      SyncerProtoUtil::CopyProtoBytesIntoBlob(
-          extended_attributes.extendedattribute(i).value(),
-          local_attribute.mutable_value());
-    }
-  }
 }
 
 // Creates a new Entry iff no Entry exists with the given id.
 // static
 void SyncerUtil::CreateNewEntry(syncable::WriteTransaction *trans,
                                 const syncable::Id& id) {
   syncable::MutableEntry entry(trans, syncable::GET_BY_ID, id);
   if (!entry.good()) {
     syncable::MutableEntry new_entry(trans, syncable::CREATE_NEW_UPDATE_ITEM,
                                      id);
@@ skipping 423 matching lines @@
 
     // |update_entry| is considered to be somewhere after |candidate|, so store
     // it as the upper bound.
     closest_sibling = candidate.Get(ID);
   }
 
   return closest_sibling;
 }
 
 }  // namespace browser_sync