Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 280004: Revert wstring patch (r29078 and follow up commits). It is causing failures o... (Closed)

Created:
11 years, 2 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, amit, pam+watch_chromium.org, Paweł Hajdan Jr., kuchhal, darin (slow to review), tim (not reviewing)
Visibility:
Public.

Description

Revert wstring patch (r29078 and follow up commits). It is causing failures on the buildbots. TBR=nsylvain Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -289 lines) Patch
M base/file_util.h View 3 chunks +8 lines, -0 lines 0 comments Download
M base/file_util.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/first_run_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox2_importer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox3_importer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/importer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/jumplist.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/printing/printing_layout_uitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/tab_contents/navigation_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_plugin_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/install.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item.h View 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item.cc View 6 chunks +26 lines, -27 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/delete_after_reboot_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/delete_tree_work_item.h View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M chrome/installer/util/move_tree_work_item.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/installer/util/move_tree_work_item.cc View 3 chunks +16 lines, -15 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/mini_installer_test/chrome_mini_installer.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M chrome/test/mini_installer_test/mini_installer_test_util.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/mini_installer_test/run_all_unittests.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/tools/crash_service/main.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome_frame/chrome_launcher.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome_frame/chrome_launcher.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome_frame/chrome_tab.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome_frame/test_utils.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M net/tools/crash_cache/crash_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/vector_canvas_unittest.cc View 44 chunks +63 lines, -64 lines 0 comments Download
M tools/memory_watcher/memory_watcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/default_plugin/plugin_database_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/image_decoder_unittest.h View 4 chunks +12 lines, -14 lines 0 comments Download
M webkit/tools/test_shell/image_decoder_unittest.cc View 10 chunks +39 lines, -46 lines 0 comments Download
M webkit/tools/webcore_unit_tests/BMPImageDecoder_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/webcore_unit_tests/ICOImageDecoder_unittest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/webcore_unit_tests/XBMImageDecoder_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698