Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6719)

Unified Diff: chrome_frame/test_utils.cc

Issue 280004: Revert wstring patch (r29078 and follow up commits). It is causing failures o... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/perf/chrome_frame_perftest.cc ('k') | net/tools/crash_cache/crash_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test_utils.cc
===================================================================
--- chrome_frame/test_utils.cc (revision 29084)
+++ chrome_frame/test_utils.cc (working copy)
@@ -15,18 +15,17 @@
// Statics
-FilePath ScopedChromeFrameRegistrar::GetChromeFrameBuildPath() {
- FilePath build_path;
+std::wstring ScopedChromeFrameRegistrar::GetChromeFrameBuildPath() {
+ std::wstring build_path;
PathService::Get(chrome::DIR_APP, &build_path);
- build_path = build_path.Append(L"servers").
- Append(L"npchrome_tab.dll");
+ file_util::AppendToPath(&build_path, L"servers\\npchrome_tab.dll");
file_util::PathExists(build_path);
return build_path;
}
void ScopedChromeFrameRegistrar::RegisterDefaults() {
- FilePath dll_path = GetChromeFrameBuildPath();
- RegisterAtPath(dll_path.value());
+ std::wstring dll_path_ = GetChromeFrameBuildPath();
+ RegisterAtPath(dll_path_);
}
void ScopedChromeFrameRegistrar::RegisterAtPath(
@@ -57,7 +56,7 @@
// Non-statics
ScopedChromeFrameRegistrar::ScopedChromeFrameRegistrar() {
- original_dll_path_ = GetChromeFrameBuildPath().ToWStringHack();
+ original_dll_path_ = GetChromeFrameBuildPath();
RegisterChromeFrameAtPath(original_dll_path_);
}
« no previous file with comments | « chrome_frame/test/perf/chrome_frame_perftest.cc ('k') | net/tools/crash_cache/crash_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698