Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: chrome_frame/test/perf/chrome_frame_perftest.cc

Issue 280004: Revert wstring patch (r29078 and follow up commits). It is causing failures o... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome_frame/chrome_tab.cc ('k') | chrome_frame/test_utils.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 #include "chrome_frame/test/perf/chrome_frame_perftest.h" 4 #include "chrome_frame/test/perf/chrome_frame_perftest.h"
5 5
6 #include <atlwin.h> 6 #include <atlwin.h>
7 #include <atlhost.h> 7 #include <atlhost.h>
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 #include <string> 10 #include <string>
(...skipping 603 matching lines...) Expand 10 before | Expand all | Expand 10 after
614 std::wstring chrome_exe_path = 614 std::wstring chrome_exe_path =
615 chrome_frame_registrar_->GetChromeFrameDllPath(); 615 chrome_frame_registrar_->GetChromeFrameDllPath();
616 EXPECT_FALSE(chrome_exe_path.empty()); 616 EXPECT_FALSE(chrome_exe_path.empty());
617 617
618 file_util::UpOneDirectory(&chrome_exe_path); 618 file_util::UpOneDirectory(&chrome_exe_path);
619 619
620 std::wstring chrome_exe_test_path = chrome_exe_path; 620 std::wstring chrome_exe_test_path = chrome_exe_path;
621 file_util::AppendToPath(&chrome_exe_test_path, 621 file_util::AppendToPath(&chrome_exe_test_path,
622 chrome::kBrowserProcessExecutableName); 622 chrome::kBrowserProcessExecutableName);
623 623
624 if (!file_util::PathExists( 624 if (!file_util::PathExists(chrome_exe_test_path)) {
625 FilePath::FromWStringHack(chrome_exe_test_path))) {
626 file_util::UpOneDirectory(&chrome_exe_path); 625 file_util::UpOneDirectory(&chrome_exe_path);
627 626
628 chrome_exe_test_path = chrome_exe_path; 627 chrome_exe_test_path = chrome_exe_path;
629 file_util::AppendToPath(&chrome_exe_test_path, 628 file_util::AppendToPath(&chrome_exe_test_path,
630 chrome::kBrowserProcessExecutableName); 629 chrome::kBrowserProcessExecutableName);
631 } 630 }
632 631
633 EXPECT_TRUE( 632 EXPECT_TRUE(file_util::PathExists(chrome_exe_test_path));
634 file_util::PathExists(FilePath::FromWStringHack(chrome_exe_test_path)));
635 633
636 return chrome_exe_path; 634 return chrome_exe_path;
637 } 635 }
638 636
639 void InitiateNextNavigation() { 637 void InitiateNextNavigation() {
640 if (browser_pid_ == 0) { 638 if (browser_pid_ == 0) {
641 std::wstring profile_directory; 639 std::wstring profile_directory;
642 if (GetUserProfileBaseDirectory(&profile_directory)) { 640 if (GetUserProfileBaseDirectory(&profile_directory)) {
643 file_util::AppendToPath(&profile_directory, 641 file_util::AppendToPath(&profile_directory,
644 GetHostProcessName(false)); 642 GetHostProcessName(false));
(...skipping 485 matching lines...) Expand 10 before | Expand all | Expand 10 after
1130 ASSERT_TRUE(silverlight_key.ReadValue(L"", &plugin_path)); 1128 ASSERT_TRUE(silverlight_key.ReadValue(L"", &plugin_path));
1131 ASSERT_FALSE(plugin_path.empty()); 1129 ASSERT_FALSE(plugin_path.empty());
1132 1130
1133 FilePath silverlight_path = FilePath::FromWStringHack(plugin_path); 1131 FilePath silverlight_path = FilePath::FromWStringHack(plugin_path);
1134 FilePath binaries_to_evict[] = {silverlight_path}; 1132 FilePath binaries_to_evict[] = {silverlight_path};
1135 1133
1136 RunStartupTest("creation_cold", "t_silverlight", "", true /* cold */, 1134 RunStartupTest("creation_cold", "t_silverlight", "", true /* cold */,
1137 arraysize(binaries_to_evict), binaries_to_evict, 1135 arraysize(binaries_to_evict), binaries_to_evict,
1138 false /* important */, true); 1136 false /* important */, true);
1139 } 1137 }
OLDNEW
« no previous file with comments | « chrome_frame/chrome_tab.cc ('k') | chrome_frame/test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698