chrome_frame/chrome_tab.cc - Issue 280004: Revert wstring patch (r29078 and follow up commits). It is causing failures o...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/chrome_tab.cc

Issue 280004: Revert wstring patch (r29078 and follow up commits). It is causing failures o... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_frame/chrome_tab.cc

===================================================================

--- chrome_frame/chrome_tab.cc (revision 29084)

+++ chrome_frame/chrome_tab.cc (working copy)

@@ -61,10 +61,10 @@

}

if (SUCCEEDED(hr)) {

- FilePath app_path =

- chrome_launcher::GetChromeExecutablePath().DirName();

- hr = registrar->AddReplacement(L"CHROME_APPPATH",

- app_path.value().c_str());

+ std::wstring app_path(

+ chrome_launcher::GetChromeExecutablePath());

+ app_path = file_util::GetDirectoryFromPath(app_path);

+ hr = registrar->AddReplacement(L"CHROME_APPPATH", app_path.c_str());

DCHECK(SUCCEEDED(hr));

}

« no previous file with comments | « chrome_frame/chrome_launcher.cc ('k') | chrome_frame/test/perf/chrome_frame_perftest.cc » ('j') | no next file with comments »