chrome/browser/importer/firefox3_importer.cc - Issue 280004: Revert wstring patch (r29078 and follow up commits). It is causing failures o...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/firefox3_importer.cc

Issue 280004: Revert wstring patch (r29078 and follow up commits). It is causing failures o... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/importer/firefox3_importer.cc

===================================================================

--- chrome/browser/importer/firefox3_importer.cc (revision 29084)

+++ chrome/browser/importer/firefox3_importer.cc (working copy)

@@ -68,7 +68,7 @@

void Firefox3Importer::ImportHistory() {

std::wstring file = source_path_;

file_util::AppendToPath(&file, L"places.sqlite");

- if (!file_util::PathExists(FilePath::FromWStringHack(file)))

+ if (!file_util::PathExists(file))

return;

sqlite3* sqlite;

@@ -116,7 +116,7 @@

void Firefox3Importer::ImportBookmarks() {

std::wstring file = source_path_;

file_util::AppendToPath(&file, L"places.sqlite");

- if (!file_util::PathExists(FilePath::FromWStringHack(file)))

+ if (!file_util::PathExists(file))

return;

sqlite3* sqlite;

@@ -314,7 +314,7 @@

std::vector<std::wstring>* files) {

std::wstring file = source_path_;

file_util::AppendToPath(&file, L"search.sqlite");

- if (!file_util::PathExists(FilePath::FromWStringHack(file)))

+ if (!file_util::PathExists(file))

return;

sqlite3* sqlite;

« no previous file with comments | « chrome/browser/importer/firefox2_importer.cc ('k') | chrome/browser/importer/importer_unittest.cc » ('j') | no next file with comments »