Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 274059: Small cleanup to extension function registration to avoid scattered definitions. (Closed)

Created:
11 years, 2 months ago by Matt Perry
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Small cleanup to extension function registration to avoid scattered definitions. BUG=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29059

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -211 lines) Patch
M chrome/browser/extensions/execute_code_in_tab_function.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/execute_code_in_tab_function.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.h View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module_constants.h View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module_constants.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_browser_actions_api.h View 1 chunk +4 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_browser_actions_api.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_function.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 2 chunks +44 lines, -86 lines 2 comments Download
M chrome/browser/extensions/extension_i18n_api.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/extension_i18n_api.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_page_actions_module.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_page_actions_module_constants.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_page_actions_module_constants.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.h View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module_constants.h View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module_constants.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/extensions/extension_test_api.h View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_test_api.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_toolstrip_api.h View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_toolstrip_api.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Matt Perry
Start in extension_function_dispatcher.cc and extension_function.h to see the meat of the change.
11 years, 2 months ago (2009-10-14 22:09:51 UTC) #1
Aaron Boodman
ok! http://codereview.chromium.org/274059/diff/1/11 File chrome/browser/extensions/extension_function_dispatcher.cc (right): http://codereview.chromium.org/274059/diff/1/11#newcode64 Line 64: void AddFactory() { Nit: I think a ...
11 years, 2 months ago (2009-10-14 22:16:29 UTC) #2
Matt Perry
11 years, 2 months ago (2009-10-14 22:19:20 UTC) #3
http://codereview.chromium.org/274059/diff/1/11
File chrome/browser/extensions/extension_function_dispatcher.cc (right):

http://codereview.chromium.org/274059/diff/1/11#newcode64
Line 64: void AddFactory() {
On 2009/10/14 22:16:29, Aaron Boodman wrote:
> Nit: I think a better name for this method would be RegisterFunction().

Done.

Powered by Google App Engine
This is Rietveld 408576698