Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3032)

Unified Diff: chrome/browser/extensions/extension_tabs_module.h

Issue 274059: Small cleanup to extension function registration to avoid scattered definitions. (Closed)
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module.h
diff --git a/chrome/browser/extensions/extension_tabs_module.h b/chrome/browser/extensions/extension_tabs_module.h
index 09147588e096e34abb8051b8441431821ef9ec76..05fdcf39a022e8af6b340161b3dd21a70eb86914 100644
--- a/chrome/browser/extensions/extension_tabs_module.h
+++ b/chrome/browser/extensions/extension_tabs_module.h
@@ -52,47 +52,61 @@ class ExtensionTabUtil {
// Windows
class GetWindowFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("windows.get")
};
class GetCurrentWindowFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("windows.getCurrent")
};
class GetLastFocusedWindowFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("windows.getLastFocused")
};
class GetAllWindowsFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("windows.getAll")
};
class CreateWindowFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("windows.create")
};
class UpdateWindowFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("windows.update")
};
class RemoveWindowFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("windows.remove")
};
// Tabs
class GetTabFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("tabs.get")
};
class GetSelectedTabFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("tabs.getSelected")
};
class GetAllTabsInWindowFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("tabs.getAllInWindow")
};
class CreateTabFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("tabs.create")
};
class UpdateTabFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("tabs.update")
};
class MoveTabFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("tabs.move")
};
class RemoveTabFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("tabs.remove")
};
class DetectTabLanguageFunction : public AsyncExtensionFunction,
public NotificationObserver {
@@ -103,9 +117,11 @@ class DetectTabLanguageFunction : public AsyncExtensionFunction,
const NotificationSource& source,
const NotificationDetails& details);
NotificationRegistrar registrar_;
+ DECLARE_EXTENSION_FUNCTION_NAME("tabs.detectLanguage")
};
class CaptureVisibleTabFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("tabs.captureVisibleTab")
};
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_TABS_MODULE_H__

Powered by Google App Engine
This is Rietveld 408576698